You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2008/08/27 08:01:45 UTC
[jira] Created: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Context.getDataSource(String) gives wrong DataSource instance
-------------------------------------------------------------
Key: SOLR-729
URL: https://issues.apache.org/jira/browse/SOLR-729
Project: Solr
Issue Type: Bug
Components: contrib - DataImportHandler
Affects Versions: 1.3
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 1.4
The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
{code}
/**
* Gets a new DataSource instance with a name.
*
* @param name Name of the dataSource as defined in the dataSource tag
* @return a new DataSource instance as configured for the named entity
* @see org.apache.solr.handler.dataimport.DataSource
*/
public abstract DataSource getDataSource(String name);
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-729)
Context.getDataSource(String) gives wrong DataSource instance
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625980#action_12625980 ]
noble.paul edited comment on SOLR-729 at 8/26/08 11:21 PM:
-----------------------------------------------------------
the javadoc itself was wrong
fixes this issue
was (Author: noble.paul):
fixes this issue
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-729:
---------------------------------------
Attachment: SOLR-729.patch
Updated patch with a test case which reproduces the bug and verifies the fix.
I plan to commit this shortly.
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: SOLR-729.patch, SOLR-729.patch, SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-729:
---------------------------------------
Priority: Major (was: Minor)
Assignee: Shalin Shekhar Mangar
Promoting to major since it makes many use-cases very difficult to implement.
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-729.patch, SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-729.
----------------------------------------
Resolution: Fixed
Committed revision 689867.
Thanks Noble!
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: SOLR-729.patch, SOLR-729.patch, SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-729:
----------------------------
Attachment: SOLR-729.patch
fixes this issue
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-729) Context.getDataSource(String) gives
wrong DataSource instance
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-729:
----------------------------
Attachment: SOLR-729.patch
* final fix and javadocs cleanup
> Context.getDataSource(String) gives wrong DataSource instance
> -------------------------------------------------------------
>
> Key: SOLR-729
> URL: https://issues.apache.org/jira/browse/SOLR-729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-729.patch, SOLR-729.patch
>
>
> The default implementation of Context -- ContextImpl#getDataSource(String) method does not use the String argument and returns the current entity's data source. The javadoc for this method in Context is also inconsistent.
> {code}
> /**
> * Gets a new DataSource instance with a name.
> *
> * @param name Name of the dataSource as defined in the dataSource tag
> * @return a new DataSource instance as configured for the named entity
> * @see org.apache.solr.handler.dataimport.DataSource
> */
> public abstract DataSource getDataSource(String name);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.