[GitHub] [hive] sourabh912 edited a comment on pull request #2638: [WIP]HIVE-25517: Moves external table find location logic to getDefaultTablePath()

[GitBox <gi...@apache.org>]

sourabh912 edited a comment on pull request #2638:
URL: https://github.com/apache/hive/pull/2638#issuecomment-919042422


   @nrg4878 : Seems like the check at this line: https://github.com/apache/hive/blob/0713b97447070df177851f8183b918dff4642f57/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java#L938 has a bug. If whRootPath is say /user/hive/warehouse and user tries to create external table like
   
   create external table TAB1 (c1 int) location '/user/hive/warehouse'; 
   The query succeeds whereas as it should have failed. 
   The reason for this is that the check whRootPath.equals(tablePath) is missing. Overall the check should look like
   
   thoughts? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org