You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/19 18:59:46 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1191: FINERACT-1087: Fixing date issues with bulk import templates
ptuomola opened a new pull request #1191:
URL: https://github.com/apache/fineract/pull/1191
## Description
Fetch only active accounts even if no office ID has been provided. Also fix the conversion of dates for the bulk import templates.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1191: FINERACT-1087: Fixing date issues with bulk import templates
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1191:
URL: https://github.com/apache/fineract/pull/1191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1191: FINERACT-1087: Fixing date issues with bulk import templates
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1191:
URL: https://github.com/apache/fineract/pull/1191#discussion_r457228525
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/AbstractWorkbookPopulator.java
##########
@@ -66,9 +66,9 @@ protected void writeDate(int colIndex, Row row, String value, CellStyle dateCell
try {
SimpleDateFormat formatinDB = null;
if (value.matches("\\d{4}-\\d{1,2}-\\d{1,2}")) {
- formatinDB = new SimpleDateFormat("yyyy-mm-dd");
+ formatinDB = new SimpleDateFormat("yyyy-MM-dd");
Review comment:
https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html:
* m = Minute in hour
* M = Month in year
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org