You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/20 11:26:00 UTC
[jira] [Work logged] (FEDIZ-232) 'wctx' parameter mandatory but
protocol does not require
[ https://issues.apache.org/jira/browse/FEDIZ-232?focusedWorklogId=201237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201237 ]
ASF GitHub Bot logged work on FEDIZ-232:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 11:25
Start Date: 20/Feb/19 11:25
Worklog Time Spent: 10m
Work Description: coheigea commented on pull request #35: FEDIZ-232 added flag to disable RequestState verification
URL: https://github.com/apache/cxf-fediz/pull/35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201237)
Time Spent: 10m
Remaining Estimate: 0h
> 'wctx' parameter mandatory but protocol does not require
> --------------------------------------------------------
>
> Key: FEDIZ-232
> URL: https://issues.apache.org/jira/browse/FEDIZ-232
> Project: CXF-Fediz
> Issue Type: Bug
> Reporter: Christian Fischer
> Assignee: Colm O hEigeartaigh
> Priority: Major
> Fix For: 1.5.0, 1.4.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For logins which are not initiated by a valid session on the RP side the user cannot be authenticated because the wctx parameter is missing or has the wrong value.
> There are at least two scenarios in which this causes a unwanted behaviour of the system.
> * First is if the IDP/login page is bookmarked and returns only later after the session on the RP is timed out.
> * Second is something similar to a IDP initiated login flow. It's not in the WS federation protocol specification but according to our tests fediz could easily allow that if the 'wctx' check is removed.
> In the protocol specification the 'wctx' parameter is also only optional, where fediz expects it to be always present. There is a comment with respect to CSRF prevention but our security team didn't see the case for this since there is no passive way of authentication is used. In fact it's the actual authentication request that is supposed to be protected, but we don't see the need.
>
> One option (if the CSRF case is valid) would be to at least disable the 'wctx' state validation by setting a flag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)