[GitHub] [incubator-daffodil] bsloane1650 edited a comment on issue #201: Fix bug in handling parse errors

[GitBox <gi...@apache.org>]

bsloane1650 edited a comment on issue #201: Fix bug in handling parse errors
URL: https://github.com/apache/incubator-daffodil/pull/201#issuecomment-484689920
 
 
   @mbeckerle 
   I think it is clear that the code prior to this PR is broken for the reasons I discussed above. Would it make sense to do?:
   
   ```
   def toParseError = new ParseError(schemaContext, dataContext, Maybe(this), Maybe.Nope)
   
   def toUnparseError = new UnparseError(schemaContext, dataContext, Maybe(this), Maybe.Nope)
   ```
   
   This maintains the invariant that exactly 1 of maybeCause and maybeFormatString is defined. I believe the content of formatString will still end up getting displayed when this is displayed as the cause of the resulting message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services