You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2012/09/27 12:06:07 UTC
[jira] [Created] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Amareshwari Sriramadasu created HADOOP-8861:
-----------------------------------------------
Summary: FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
Key: HADOOP-8861
URL: https://issues.apache.org/jira/browse/HADOOP-8861
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 1.0.3
Reporter: Amareshwari Sriramadasu
Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464624#comment-13464624 ]
Hadoop QA commented on HADOOP-8861:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546845/HADOOP-8861.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1537//console
This message is automatically generated.
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475863#comment-13475863 ]
Uma Maheswara Rao G commented on HADOOP-8861:
---------------------------------------------
Thanks Amareshwari, for the patch.
Change make sense to me. Do you mind having a small test like TestLocalFileSystem#testSyncable in trunk.
Other than that, +1 for the patch.
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-8861:
--------------------------------------------
Attachment: HADOOP-8861.patch
The trivial patch doing the fix
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480326#comment-13480326 ]
Uma Maheswara Rao G commented on HADOOP-8861:
---------------------------------------------
I have just committed to branch-1.
Committed revision 1400256.
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 1.2.0
>
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-8861:
--------------------------------------------
Attachment: HADOOP-8861-2.patch
Patch with test added in TestLocalFileSystem
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465354#comment-13465354 ]
Amareshwari Sriramadasu commented on HADOOP-8861:
-------------------------------------------------
Hadoop QA failed applying the patch as the patch is against branch-1. The issue does not exist in trunk, so fix is needed only for branch-1
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479964#comment-13479964 ]
Uma Maheswara Rao G commented on HADOOP-8861:
---------------------------------------------
+1, I will commit it in some time. Thanks Amareshwari
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465390#comment-13465390 ]
Amareshwari Sriramadasu commented on HADOOP-8861:
-------------------------------------------------
I ran tests on branch-1, both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file. I see the same behavior in jenkins builds as well - https://builds.apache.org/job/Hadoop-1-Code-Coverage/159/consoleText
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-8861:
--------------------------------------------
Target Version/s: 1.1.0
Status: Patch Available (was: Open)
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE reassigned HADOOP-8861:
----------------------------------------------
Assignee: Amareshwari Sriramadasu
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479781#comment-13479781 ]
Amareshwari Sriramadasu commented on HADOOP-8861:
-------------------------------------------------
Hadoop QA failed to apply the patch since it is against branch-1. I ran the tests on box, the result is the same as earlier - both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file.
Also, the TestLocalFileSystem result:
[junit] Running org.apache.hadoop.fs.TestLocalFileSystem
[junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 12.196 sec
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8861) FSDataOutputStream.sync should call
flush() if the underlying wrapped stream is not Syncable
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-8861:
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 1.2.0
>
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8861) FSDataOutputStream.sync should
call flush() if the underlying wrapped stream is not Syncable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478940#comment-13478940 ]
Hadoop QA commented on HADOOP-8861:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549677/HADOOP-8861-2.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1646//console
This message is automatically generated.
> FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-8861
> URL: https://issues.apache.org/jira/browse/HADOOP-8861
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Amareshwari Sriramadasu
> Attachments: HADOOP-8861-2.patch, HADOOP-8861.patch
>
>
> Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.
> This behavior is already present in trunk, but branch-1 does not have this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira