You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/08/23 04:36:01 UTC

[GitHub] [lucene-solr] tflobbe commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

tflobbe commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524169087
 
 
   Thanks @atris. Changes look good to me, however, I think there are a couple more cases that we could change:
   * `ConfigNameConstants`
   * `Variable.Type`
   * `SolrRequest`
   * `ZkStateReader.KNOWN_CLUSTER_PROPS`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org