You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by Wosin <gi...@git.apache.org> on 2018/07/20 22:26:49 UTC
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
GitHub user Wosin opened a pull request:
https://github.com/apache/bahir-flink/pull/29
[BAHIR-173]Update Flink version to 1.5.1
This PR updates the version of Flink to the last official release 1.5.1.
This update required updating akka version in `flink-connector-akka` module.
`MultiException` was removed since it was imported directly from Flink and is not present in Flink 1.5.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wosin/bahir-flink BAHIR-173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit e533957d7725bc4a861d9b78d5d9dce398a50f78
Author: Dominik.Wosinski <bl...@...>
Date: 2018-07-20T21:47:12Z
[BAHIR-173]Update Flink version to 1.5.1
----
---
[GitHub] bahir-flink issue #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/29
LGTM, any other comments?
---
[GitHub] bahir-flink issue #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/29
@eskabetxe do you have a jira account so that I can assign the jira to yourself?
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204740329
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
- CACHE_NAME=JDK8_F130_B
- jdk: openjdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
--- End diff --
If scala 2.10 is deprecated, I would remove them from the travis profiles (as they are the ones failing) and would submit support for 2.12 as a new PR.
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/29
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by Wosin <gi...@git.apache.org>.
Github user Wosin commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204741774
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
- CACHE_NAME=JDK8_F130_B
- jdk: openjdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
--- End diff --
Ok, this seems reasonable. I will remove them completely then.
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204484975
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
- CACHE_NAME=JDK8_F130_B
- jdk: openjdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
--- End diff --
the version on scala 2.10 was deprecated on flink version 1.4.0
you have to remove this test
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by Wosin <gi...@git.apache.org>.
Github user Wosin commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204503370
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
- CACHE_NAME=JDK8_F130_B
- jdk: openjdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
--- End diff --
I know:) I am switching this to scala 2.12
---
[GitHub] bahir-flink pull request #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204484791
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- - FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
+ - FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
--- End diff --
the version on scala 2.10 was deprecated on flink version 1.4.0
you have to remove this test
---
[GitHub] bahir-flink issue #29: [BAHIR-173]Update Flink version to 1.5.1
Posted by eskabetxe <gi...@git.apache.org>.
Github user eskabetxe commented on the issue:
https://github.com/apache/bahir-flink/pull/29
yes same user
---