You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/29 22:00:57 UTC

Review Request 71188: Added metrics for quota limits.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71188/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-9603
    https://issues.apache.org/jira/browse/MESOS-9603


Repository: mesos


Description
-------

This is done similarly to to the existing quota guarantee metrics.

However, the logic is adjusted given the presence of bugs in the
existing implementation. In the case that a non-default quota gets
updated to a new value, the existing logic would fail to add the
new metric and the metric exposed to the user would be stuck with
the original value. To resolve this, we now remove the original
metrics and subsequently add the new ones.


Diffs
-----

  src/master/allocator/mesos/metrics.hpp fa2a5dcc8578a687a0240a41daf9575ec6a5710b 
  src/master/allocator/mesos/metrics.cpp 2d727579018e8b018070e7fcc3a70185734d5a89 


Diff: https://reviews.apache.org/r/71188/diff/1/


Testing
-------

Tested in the following patch.


Thanks,

Benjamin Mahler

Re: Review Request 71188: Added metrics for quota limits.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71188/#review216928
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for fixing the bug!


src/master/allocator/mesos/metrics.cpp
Lines 131-132 (original), 137-138 (patched)
<https://reviews.apache.org/r/71188/#comment304162>

    Remove the TODO



src/master/allocator/mesos/metrics.cpp
Lines 164-165 (patched)
<https://reviews.apache.org/r/71188/#comment304163>

    we can compare directly here:
    
    if (quota == DEFAULT_QUOTA) ...


- Meng Zhu


On July 29, 2019, 3 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71188/
> -----------------------------------------------------------
> 
> (Updated July 29, 2019, 3 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9603
>     https://issues.apache.org/jira/browse/MESOS-9603
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is done similarly to to the existing quota guarantee metrics.
> 
> However, the logic is adjusted given the presence of bugs in the
> existing implementation. In the case that a non-default quota gets
> updated to a new value, the existing logic would fail to add the
> new metric and the metric exposed to the user would be stuck with
> the original value. To resolve this, we now remove the original
> metrics and subsequently add the new ones.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/metrics.hpp fa2a5dcc8578a687a0240a41daf9575ec6a5710b 
>   src/master/allocator/mesos/metrics.cpp 2d727579018e8b018070e7fcc3a70185734d5a89 
> 
> 
> Diff: https://reviews.apache.org/r/71188/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in the following patch.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>