You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/02/28 18:47:26 UTC
Review Request 57155: Increase Ranger/Atlas timeout (check znode)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57155/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
Bugs: AMBARI-20242
https://issues.apache.org/jira/browse/AMBARI-20242
Repository: ambari
Description
-------
Increase to ranger/atlas timeouts in order to avoid blueprint based install timeouts
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py c25445c
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 15f7cf7
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57
ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py cd2fac8
ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876
ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e
Diff: https://reviews.apache.org/r/57155/diff/
Testing
-------
done.
Thanks,
Oliver Szabo
Re: Review Request 57155: Increase Ranger/Atlas timeout (check znode)
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57155/#review167239
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
Lines 761 (patched)
<https://reviews.apache.org/r/57155/#comment239398>
Why wee need this if there is already a ```@retry``` annotation of the ```check_znode``` method?
- Sebastian Toader
On Feb. 28, 2017, 7:47 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57155/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:47 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20242
> https://issues.apache.org/jira/browse/AMBARI-20242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Increase to ranger/atlas timeouts in order to avoid blueprint based install timeouts
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py c25445c
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 15f7cf7
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py cd2fac8
> ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876
> ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e
>
>
> Diff: https://reviews.apache.org/r/57155/diff/1/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 57155: Increase Ranger/Atlas timeout (check znode)
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57155/#review167172
-----------------------------------------------------------
Ship it!
The patch looks fine to me. It might be good to have somebody with more knowledge of Ranger and Atlas review the stack-level changes as well.
Thanks.
- Robert Nettleton
On Feb. 28, 2017, 6:47 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57155/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:47 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20242
> https://issues.apache.org/jira/browse/AMBARI-20242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Increase to ranger/atlas timeouts in order to avoid blueprint based install timeouts
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py c25445c
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 15f7cf7
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py cd2fac8
> ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876
> ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e
>
> Diff: https://reviews.apache.org/r/57155/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 57155: Increase Ranger/Atlas timeout (check znode)
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57155/#review167178
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Feb. 28, 2017, 6:47 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57155/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:47 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-20242
> https://issues.apache.org/jira/browse/AMBARI-20242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Increase to ranger/atlas timeouts in order to avoid blueprint based install timeouts
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py c25445c
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 15f7cf7
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py cd2fac8
> ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876
> ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e
>
> Diff: https://reviews.apache.org/r/57155/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>