[GitHub] [arrow] westonpace commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #12113:
URL: https://github.com/apache/arrow/pull/12113#discussion_r806241299



##########
File path: r/src/compute-exec.cpp
##########
@@ -217,7 +217,8 @@ std::shared_ptr<compute::ExecNode> ExecNode_Join(
     const std::shared_ptr<compute::ExecNode>& input, int type,
     const std::shared_ptr<compute::ExecNode>& right_data,
     std::vector<std::string> left_keys, std::vector<std::string> right_keys,
-    std::vector<std::string> left_output, std::vector<std::string> right_output) {
+    std::vector<std::string> left_output, std::vector<std::string> right_output,
+    std::string output_prefix_for_left, std::string output_prefix_for_right) {

Review comment:
       prefix -> suffix

##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -143,8 +142,8 @@ test_that("Error handling", {
   )
 })
 
-# TODO: test duplicate col names
-# TODO: casting: int and float columns?
+# # TODO: test duplicate col names
+# # TODO: casting: int and float columns?

Review comment:
       ```suggestion
   # TODO: test duplicate col names
   # TODO: casting: int and float columns?
   ```

##########
File path: r/R/query-engine.R
##########
@@ -278,7 +279,7 @@ ExecNode <- R6Class("ExecNode",
         ExecNode_Aggregate(self, options, target_names, out_field_names, key_names)
       )
     },
-    Join = function(type, right_node, by, left_output, right_output) {
+    Join = function(type, right_node, by, left_output, right_output, left_prefix, right_prefix) {

Review comment:
       prefix -> suffix

##########
File path: r/R/query-engine.R
##########
@@ -287,7 +288,9 @@ ExecNode <- R6Class("ExecNode",
           left_keys = names(by),
           right_keys = by,
           left_output = left_output,
-          right_output = right_output
+          right_output = right_output,
+          output_prefix_for_left = left_prefix,

Review comment:
       prefix -> suffix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org