[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #570: Clear selection data when ephemeral windows close

["scholarsmate (via GitHub)" <gi...@apache.org>]

scholarsmate commented on code in PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570#discussion_r1158584768


##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -220,6 +220,7 @@ limitations under the License.
         (targetLine == 0 ? 0 : targetLine - 1) * lineHeight
     }
     closeEphemeralWindows()
+    clearDataDisplays()

Review Comment:
   Is there any time where we'd close the ephemeral window and not clear the data display?  If not, let's just clear the data display ni the close ephemeral window function instead to make it simpler and less error prone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org