[GitHub] [apisix] tokers commented on a change in pull request #3991: fix: ensure automic operation in limit-count plugin

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #3991:
URL: https://github.com/apache/apisix/pull/3991#discussion_r608589033



##########
File path: apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -30,6 +29,13 @@ local mt = {
 }
 
 
+local script = "if redis.call('ttl', KEYS[1]) < 0 then "

Review comment:
       Ditto.

##########
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##########
@@ -30,6 +29,13 @@ local mt = {
 }
 
 
+local script = "if redis.call('ttl', KEYS[1]) < 0 then "

Review comment:
       What about using long string quotes.
   
   ```lua
   local scripts [=[ .... ]=]
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org