You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 17:30:28 UTC
[jira] [Created] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Don't hardcode hdfs.audit.logger in the scripts
-----------------------------------------------
Key: HADOOP-8224
URL: https://issues.apache.org/jira/browse/HADOOP-8224
Project: Hadoop Common
Issue Type: Improvement
Components: conf
Affects Versions: 2.0.0
Reporter: Eli Collins
The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274008#comment-13274008 ]
Hudson commented on HADOOP-8224:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1077 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1077/])
HADOOP-8224. Don't hardcode hdfs.audit.logger in the scripts. Contributed by Tomohiko Kinebuchi (Revision 1337339)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins reassigned HADOOP-8224:
-----------------------------------
Assignee: Tomohiko Kinebuchi
Thanks Tomohiko, I've added you as a contributor and assigned this to you.
How did you test this change? Looks like your change should be sufficient, it's not necessary to update hadoop-daemon.sh with an export similar to the other _LOGGER variables.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262331#comment-13262331 ]
Eli Collins commented on HADOOP-8224:
-------------------------------------
To test you'll want to build the tarball and test that HDFS_AUDIT_LOGGER is respected when set in hadoop-env.sh, eg if set to the WARNING level you don't see audit logging, and if set to INFO you do.
Btw I noticed while reviewing this that audit logging is now enabled by default, will address that in HADOOP-8316.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8224.
---------------------------------
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.2-alpha
>
> Attachments: hadoop-8224.txt, HADOOP-8224.txt, HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8224:
--------------------------------
Fix Version/s: (was: 2.0.0)
2.0.1
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.1
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Tomohiko Kinebuchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259381#comment-13259381 ]
Tomohiko Kinebuchi commented on HADOOP-8224:
--------------------------------------------
Thank you for your comment.
I created and attached a new patch including first fix and a fix for hadoop-daemon.sh.
I am thinking how do I test these fixes.
1. Kick a Hadoop cluster with this shell, and check existence of log messages in hdfs-audit.log.
2. Kick a Hadoop cluster with this shell, and get configuration values from Configuration class.
Do you have some other testing processes?
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273986#comment-13273986 ]
Hudson commented on HADOOP-8224:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1041 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1041/])
HADOOP-8224. Don't hardcode hdfs.audit.logger in the scripts. Contributed by Tomohiko Kinebuchi (Revision 1337339)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273474#comment-13273474 ]
Patrick Hunt commented on HADOOP-8224:
--------------------------------------
Reviewed the patch, looks good to me.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273574#comment-13273574 ]
Hudson commented on HADOOP-8224:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2250 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2250/])
HADOOP-8224. Don't hardcode hdfs.audit.logger in the scripts. Contributed by Tomohiko Kinebuchi (Revision 1337339)
Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Tomohiko Kinebuchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomohiko Kinebuchi updated HADOOP-8224:
---------------------------------------
Attachment: HADOOP-8224.txt
Attached a patch.
Could someone give me contributor permission and assign to me?
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Attachments: HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Tomohiko Kinebuchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomohiko Kinebuchi updated HADOOP-8224:
---------------------------------------
Attachment: HADOOP-8224.txt
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273548#comment-13273548 ]
Hudson commented on HADOOP-8224:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2233 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2233/])
HADOOP-8224. Don't hardcode hdfs.audit.logger in the scripts. Contributed by Tomohiko Kinebuchi (Revision 1337339)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8224:
--------------------------------
Attachment: hadoop-8224.txt
Patch attached. Updated Tomohiko's patch to apply atop HADOOP-8316. Running the testing I mentioned in the previous comment now.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273403#comment-13273403 ]
Eli Collins commented on HADOOP-8224:
-------------------------------------
Verified from a tarball install that there is no hdfs audit log by default and that exporting HDFS_AUDIT_LOGGER to INFO,RFAAUDIT in hadoop-env.sh enables it.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273539#comment-13273539 ]
Hudson commented on HADOOP-8224:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2307 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2307/])
HADOOP-8224. Don't hardcode hdfs.audit.logger in the scripts. Contributed by Tomohiko Kinebuchi (Revision 1337339)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273521#comment-13273521 ]
Patrick Hunt commented on HADOOP-8224:
--------------------------------------
+1
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8224) Don't hardcode hdfs.audit.logger in
the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HADOOP-8224.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Hadoop Flags: Reviewed
I've committed this and merged to branch-2. Thanks Tomohiko!
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Fix For: 2.0.0
>
> Attachments: HADOOP-8224.txt, HADOOP-8224.txt, hadoop-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8224) Don't hardcode hdfs.audit.logger
in the scripts
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259312#comment-13259312 ]
Eli Collins commented on HADOOP-8224:
-------------------------------------
Actually, it does look like the export in hadoop-daemon.sh is necessary, this is for the case where people don't have hadoop-env.sh in their conf dir.
> Don't hardcode hdfs.audit.logger in the scripts
> -----------------------------------------------
>
> Key: HADOOP-8224
> URL: https://issues.apache.org/jira/browse/HADOOP-8224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Tomohiko Kinebuchi
> Attachments: HADOOP-8224.txt
>
>
> The HADOOP_*OPTS defined for HDFS in hadoop-env.sh hard-code the hdfs.audit.logger (is explicitly set via "-Dhdfs.audit.logger=INFO,RFAAUDIT") so it's not overridable. Let's allow someone to override it as we do the other parameters by introducing HADOOP_AUDIT_LOGGER.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira