You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/31 09:43:30 UTC
[PR] Enhance Spotless rules for source consistency [shardingsphere]
terrymanu opened a new pull request, #39667:
URL: https://github.com/apache/shardingsphere/pull/39667
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhance Spotless rules for source consistency [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39667:
URL: https://github.com/apache/shardingsphere/pull/39667#issuecomment-5477234290
### Result
**Review Result: Mergeable**
### Evidence
- Clean runs incur an additional 4.83–5.60 seconds while executing the new `shortenFullyQualifiedTypes` and `removeUnusedImports` checks across all Java files.
- This cost affects only formatting and validation, not ShardingSphere production runtime paths.
- All 21 changed files were reviewed; Spotless, Checkstyle, and scoped test compilation passed.
- Normalized bytecode for all four changed production classes was identical between the base and PR head.
- The six GitHub Workflow files contain only trailing-whitespace removal and no behavioral changes.
### Coverage
- This result covers the code correctness of PR head `9fb2725f54b4cff11a74486050edfd3c2060ec1e`.
- The previous sole blocker is withdrawn; no other confirmed issues or evidence gaps remain.
- CI and GitHub Actions status were not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhance Spotless rules for source consistency [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39667:
URL: https://github.com/apache/shardingsphere/pull/39667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org