You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/10/23 08:19:13 UTC
[PR] feat(desktop): prefill compaction thresholds when adding models [maka]
me2seeks opened a new pull request, #6264:
URL: https://github.com/apache/maka/pull/6264
## Summary
The explicit Add model form now proposes a saved compaction threshold of 90% of known input capacity, following the narrower context-window/input-limit fact. For example, entering a 500,000-token window proposes 450,000. The proposal follows capacity/model edits until the user edits or clears it; submission saves the value actually shown.
Empty thresholds still disable proactive compaction. Existing connections and model-discovery refreshes are unchanged. This is a reviewed form default, not the global read-side policy withdrawn in #5574 / #5980. Add-form help explains the behavior in all three locales.
Fixes #6260
## Verification
- Three mounted production-component regressions fail with the original AddModelDialog. They verify final-capacity updates, explicit overrides, clear-to-disable, known/unknown model metadata, and the saved payload.
- Five affected Desktop suites: 91 passed; renderer architecture: 168 passed. Full repository build, Desktop typecheck (including stories/assistant web), lint/format, Desktop knip and `git diff --check` passed.
- Storybook built before/after; agent-browser drove the production Add model story and confirmed 500,000 → 450,000, then cleared the field and changed capacity to 600,000 while it stayed empty. No live configuration or provider requests were used.
| Before | After |
| --- | --- |
|  |  |
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the form change and regressions, used agent-browser for browser verification/screenshots, and performed automated local review. Independent human review remains required.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): prefill compaction thresholds when adding models [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #6264:
URL: https://github.com/apache/maka/pull/6264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): prefill compaction thresholds when adding models [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #6264:
URL: https://github.com/apache/maka/pull/6264#issuecomment-6360652120
Automated local review by Codex; this is not an independent human review or approval.
No actionable findings remain after tracing the actual AddModelDialog, metadata/override limit resolution, displayed draft, submission payload, clear behavior, and both settings/default-model entry points.
1. **Optimal for the actual problem:** yes. Propose an explicit value in the existing form, using the existing numeric draft's absent-versus-cleared distinction. Empty runtime settings remain opt-in; existing connections and discovery refresh are unchanged.
2. **Production deletions:** none identified. The final solution adds no effect, touched flag, migration, backend default or parallel limit resolver.
3. **Low-quality tests:** none identified. Three mounted component journeys verify visible values and actual submit payloads; all fail with the original production component. Browser checks cover the actual clear button and published before/after evidence.
4. **Deeper refactor:** not required. The form owns this proposal; core retains model facts and runtime retains explicit-threshold semantics.
5. **Ready to merge:** not yet. This user-visible default changes newly added model behavior and needs independent human review under CONTRIBUTING.md plus exact-head CI. Automated review is not approval.
6. **Residual risks/gaps:** 90% is a form suggestion, not a guarantee of provider capacity or quality; users can edit or clear it. No migration/backfill or automatic discovery seeding is included. Five affected Desktop suites (91 tests), renderer architecture (168 tests), full build, Desktop typecheck, lint/format and Desktop knip pass. Storybook browser checks and immutable before/after screenshots are attached to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org