You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/10/23 23:03:14 UTC

Review Request 39612: Do not force a core dump if strerror fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39612/
-----------------------------------------------------------

Review request for qpid and Alan Conway.


Bugs: PROTON-1029
    https://issues.apache.org/jira/browse/PROTON-1029


Repository: qpid-proton-git


Description
-------

The current implementation seems... a bit much.   This patch pre-seeds a simple default message in case strerror fails or is not available.


Diffs
-----

  proton-c/src/platform.c 5470c5a51d5815106c26ae6522c60b3c7b78a422 

Diff: https://reviews.apache.org/r/39612/diff/


Testing
-------

Unit tests pass.
stepped through new path w/debugger


Thanks,

Kenneth Giusti

Re: Review Request 39612: Do not force a core dump if strerror fails

Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39612/#review104007
-----------------------------------------------------------

Ship it!


Ship It!

- Alan Conway


On Oct. 23, 2015, 9:03 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39612/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:03 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Bugs: PROTON-1029
>     https://issues.apache.org/jira/browse/PROTON-1029
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> The current implementation seems... a bit much.   This patch pre-seeds a simple default message in case strerror fails or is not available.
> 
> 
> Diffs
> -----
> 
>   proton-c/src/platform.c 5470c5a51d5815106c26ae6522c60b3c7b78a422 
> 
> Diff: https://reviews.apache.org/r/39612/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass.
> stepped through new path w/debugger
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>