You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2009/04/02 12:51:54 UTC

[PATCH] Fix issue #2586

Hi,

I am attaching a patch which fixes issue #2586. If there is no comments on
this, I shall commit it tomorrow.

[[[
Fix issue #2586.

* subversion/libsvn_client/add.c
  (mkdir_urls): Early exit when there is a mix of URLs and local paths.
]]]

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1518640

Re: [PATCH] Fix issue #2586

Posted by Senthil Kumaran S <se...@collab.net>.
Senthil Kumaran S wrote:
> Bert Huijben wrote:
>> svn_path_is_url() doesn't need a pool...
>> (And I don't know what hostname apr_uri_parse provides for
>> file:///G:/repos/dir/file.. Might be "" or NULL)
> 
> Thanks for your review. I shall modify the code and commit asap.

Committed in r36944.

-- 
Senthil Kumaran S
http://www.stylesen.org/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1520702

Re: [PATCH] Fix issue #2586

Posted by Senthil Kumaran S <se...@collab.net>.
Hi Bert,

Bert Huijben wrote:
> svn_path_is_url() doesn't need a pool...
> (And I don't know what hostname apr_uri_parse provides for
> file:///G:/repos/dir/file.. Might be "" or NULL)

Thanks for your review. I shall modify the code and commit asap.

-- 
Senthil Kumaran S
http://www.stylesen.org/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1519933

RE: [PATCH] Fix issue #2586

Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: Senthil Kumaran S [mailto:senthil@collab.net]
> Sent: donderdag 2 april 2009 14:52
> To: dev@subversion.tigris.org
> Subject: [PATCH] Fix issue #2586
> 
> Hi,
> 
> I am attaching a patch which fixes issue #2586. If there is no comments on
> this, I shall commit it tomorrow.
> 
> [[[
> Fix issue #2586.
> 
> * subversion/libsvn_client/add.c
>   (mkdir_urls): Early exit when there is a mix of URLs and local paths.
> ]]]

I think you could use svn_path_is_url() ?

If you use an iterpool you should create it outside the loop, clear it
before use and destroy it after the loop. (Your loop creates a new iterpool
for every iteration and never destroys the iterpool).

svn_path_is_url() doesn't need a pool...
(And I don't know what hostname apr_uri_parse provides for
file:///G:/repos/dir/file.. Might be "" or NULL)

Thanks,

	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1518802