You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Radhika Kundam <ra...@gmail.com> on 2020/10/30 01:44:11 UTC
Review Request 72994: ATLAS-4010: Sort properties lexicographically in
pom.xml for readability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010
Repository: atlas
Description
-------
Properties are in random order under <properties> section in pom.xml
For better readability, need to sort properties in lexicographic order.
Diffs
-----
distro/pom.xml db1f23acd
docs/pom.xml f22f9e2ff
pom.xml aca36aaee
webapp/pom.xml 5a8cfe616
Diff: https://reviews.apache.org/r/72994/diff/1/
Testing
-------
Build is successful.
Thanks,
Radhika Kundam
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Radhika Kundam <ra...@gmail.com>.
> On Oct. 30, 2020, 5:43 a.m., Ashutosh Mestry wrote:
> > distro/pom.xml
> > Line 51 (original), 39 (patched)
> > <https://reviews.apache.org/r/72994/diff/1/?file=2241742#file2241742line51>
> >
> > nit: Remove extraneous tabs.
Fixed, attached the patach with updates.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222145
-----------------------------------------------------------
On Oct. 30, 2020, 5:46 p.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 5:46 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/1/
>
>
> Testing
> -------
>
> Build is successful.
>
>
> File Attachments
> ----------------
>
> Removing extra spaces
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
>
>
> Thanks,
>
> Radhika Kundam
>
>
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222145
-----------------------------------------------------------
distro/pom.xml
Line 51 (original), 39 (patched)
<https://reviews.apache.org/r/72994/#comment311213>
nit: Remove extraneous tabs.
- Ashutosh Mestry
On Oct. 30, 2020, 1:44 a.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 1:44 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/1/
>
>
> Testing
> -------
>
> Build is successful.
>
>
> Thanks,
>
> Radhika Kundam
>
>
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222197
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Nov. 9, 2020, 2:17 p.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2020, 2:17 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/2/
>
>
> Testing
> -------
>
> Build is successful.
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/178/
>
>
> File Attachments
> ----------------
>
> Removing extra spaces
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
>
>
> Thanks,
>
> Radhika Kundam
>
>
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
-----------------------------------------------------------
(Updated Nov. 9, 2020, 2:17 p.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010
Repository: atlas
Description
-------
Properties are in random order under <properties> section in pom.xml
For better readability, need to sort properties in lexicographic order.
Diffs
-----
distro/pom.xml db1f23acd
docs/pom.xml f22f9e2ff
pom.xml aca36aaee
webapp/pom.xml 5a8cfe616
Diff: https://reviews.apache.org/r/72994/diff/2/
Testing (updated)
-------
Build is successful.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/178/
File Attachments
----------------
Removing extra spaces
https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
Thanks,
Radhika Kundam
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
-----------------------------------------------------------
(Updated Nov. 2, 2020, 12:08 p.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Changes
-------
Removed the extra tab spaces for conf properties
Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010
Repository: atlas
Description
-------
Properties are in random order under <properties> section in pom.xml
For better readability, need to sort properties in lexicographic order.
Diffs (updated)
-----
distro/pom.xml db1f23acd
docs/pom.xml f22f9e2ff
pom.xml aca36aaee
webapp/pom.xml 5a8cfe616
Diff: https://reviews.apache.org/r/72994/diff/2/
Changes: https://reviews.apache.org/r/72994/diff/1-2/
Testing
-------
Build is successful.
File Attachments
----------------
Removing extra spaces
https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
Thanks,
Radhika Kundam
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222154
-----------------------------------------------------------
distro/pom.xml
Line 51 (original), 39 (patched)
<https://reviews.apache.org/r/72994/#comment311220>
avoid extra spaces in lines 39-60. These properties are written to conf file and may be written with intendation.
distro/pom.xml
Line 346 (original), 333 (patched)
<https://reviews.apache.org/r/72994/#comment311221>
avoid extra spaces in lines 333-337
distro/pom.xml
Line 425 (original), 412 (patched)
<https://reviews.apache.org/r/72994/#comment311222>
avoid extra spaces in lines 412-421
- Sarath Subramanian
On Oct. 30, 2020, 10:46 a.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 10:46 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/1/
>
>
> Testing
> -------
>
> Build is successful.
>
>
> File Attachments
> ----------------
>
> Removing extra spaces
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
>
>
> Thanks,
>
> Radhika Kundam
>
>
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
-----------------------------------------------------------
(Updated Oct. 30, 2020, 5:46 p.m.)
Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
Changes
-------
Removed the extra tabs as mentioned in comments.
Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010
Repository: atlas
Description
-------
Properties are in random order under <properties> section in pom.xml
For better readability, need to sort properties in lexicographic order.
Diffs
-----
distro/pom.xml db1f23acd
docs/pom.xml f22f9e2ff
pom.xml aca36aaee
webapp/pom.xml 5a8cfe616
Diff: https://reviews.apache.org/r/72994/diff/1/
Testing
-------
Build is successful.
File Attachments (updated)
----------------
Removing extra spaces
https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
Thanks,
Radhika Kundam
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Radhika Kundam <ra...@gmail.com>.
> On Oct. 30, 2020, 2:57 p.m., Madhan Neethiraj wrote:
> > distro/pom.xml
> > Line 51 (original), 39 (patched)
> > <https://reviews.apache.org/r/72994/diff/1/?file=2241742#file2241742line51>
> >
> > The value of property graph.index.properties is written to configuration file, refer to distro/src/conf/atlas-application.properties. Hence leading spaces should be avoided.
Fixed, attached the patach with updates.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222148
-----------------------------------------------------------
On Oct. 30, 2020, 5:46 p.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 5:46 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/1/
>
>
> Testing
> -------
>
> Build is successful.
>
>
> File Attachments
> ----------------
>
> Removing extra spaces
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
>
>
> Thanks,
>
> Radhika Kundam
>
>
Re: Review Request 72994: ATLAS-4010: Sort properties
lexicographically in pom.xml for readability
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222148
-----------------------------------------------------------
distro/pom.xml
Line 51 (original), 39 (patched)
<https://reviews.apache.org/r/72994/#comment311214>
The value of property graph.index.properties is written to configuration file, refer to distro/src/conf/atlas-application.properties. Hence leading spaces should be avoided.
- Madhan Neethiraj
On Oct. 30, 2020, 1:44 a.m., Radhika Kundam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 1:44 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
>
>
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Properties are in random order under <properties> section in pom.xml
>
> For better readability, need to sort properties in lexicographic order.
>
>
> Diffs
> -----
>
> distro/pom.xml db1f23acd
> docs/pom.xml f22f9e2ff
> pom.xml aca36aaee
> webapp/pom.xml 5a8cfe616
>
>
> Diff: https://reviews.apache.org/r/72994/diff/1/
>
>
> Testing
> -------
>
> Build is successful.
>
>
> Thanks,
>
> Radhika Kundam
>
>