You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by miroswan <gi...@git.apache.org> on 2018/02/05 19:52:39 UTC

[GitHub] mesos pull request #262: Updating reservation.md

GitHub user miroswan opened a pull request:

    https://github.com/apache/mesos/pull/262

    Updating reservation.md

    When using the Operator API, I came to this document to get a better understand of resource reservations. It wasn't clear to me that the reservation or reservations keys were a requirement given that the principal configuration is optional. What I do know is that the role can be set in the resource object or the reservation object. I think we might as well instruct users to set the role in the reservation object so it is more clear that it is required to successfully POST the request. After a quick google search, I noted that another user ran into the same issue and posted about it in IRC. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/miroswan/mesos master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mesos/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit e12a4beaa8fbb4845cec80e1bbcd6bda59bc22da
Author: Demitri Swan <ds...@...>
Date:   2018-02-05T19:48:53Z

    Updating reservation.md

----


---

[GitHub] mesos issue #262: Updating reservation.md

Posted by bmahler <gi...@git.apache.org>.

Github user bmahler commented on the issue:

    https://github.com/apache/mesos/pull/262
  
    @mpark I didn't realize we also supported setting role within `reservation`, should this be adding to `reservations`? Or do we officially support `reservation` with type `DYNAMIC` & `role`?


---

[GitHub] mesos issue #262: Updating reservation.md

Posted by mpark <gi...@git.apache.org>.

Github user mpark commented on the issue:

    https://github.com/apache/mesos/pull/262
  
    7cee22c


---

[GitHub] mesos pull request #262: Updating reservation.md

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/mesos/pull/262


---

[GitHub] mesos issue #262: Updating reservation.md

Posted by vinodkone <gi...@git.apache.org>.

Github user vinodkone commented on the issue:

    https://github.com/apache/mesos/pull/262
  
    @mpark @bmahler Can you guys review?


---