You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/29 10:55:53 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1218: application service discovery support nacos reporter
AlexStocks commented on a change in pull request #1218:
URL: https://github.com/apache/dubbo-go/pull/1218#discussion_r641923708
##########
File path: metadata/report/nacos/report.go
##########
@@ -52,14 +53,34 @@ type nacosMetadataReport struct {
// GetAppMetadata get metadata info from nacos
func (n *nacosMetadataReport) GetAppMetadata(metadataIdentifier *identifier.SubscriberMetadataIdentifier) (*common.MetadataInfo, error) {
- // TODO will implement
- panic("implement me")
+ data, err := n.getConfig(vo.ConfigParam{
+ DataId: metadataIdentifier.GetIdentifierKey(),
+ Group: metadataIdentifier.Group,
+ })
+
Review comment:
delete this blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org