You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Reranko05 (via GitHub)" <gi...@apache.org> on 2026/07/29 12:41:36 UTC
[PR] GH-50706: [C++] Migrate extension type serialization to JsonWriter [arrow]
Reranko05 opened a new pull request, #50708:
URL: https://github.com/apache/arrow/pull/50708
### Rationale for this change
This PR continues the simdjson migration by replacing RapidJSON's `Writer` API with `JsonWriter` in extension type serialization.
### What changes are included in this PR?
* Replace RapidJSON writer usage with `JsonWriter` in:
* `FixedShapeTensorType::Serialize()`
* `VariableShapeTensorType::Serialize()`
* `OpaqueType::Serialize()`
* Remove `rapidjson::Writer` usage from the migrated serializers.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
Closes: #50706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50706: [C++] Migrate extension type serialization to JsonWriter [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50708:
URL: https://github.com/apache/arrow/pull/50708#issuecomment-5117884961
:warning: GitHub issue #50706 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50706: [C++] Migrate extension type serialization to JsonWriter [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #50708:
URL: https://github.com/apache/arrow/pull/50708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50706: [C++] Migrate extension type serialization to JsonWriter [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50708:
URL: https://github.com/apache/arrow/pull/50708#issuecomment-5138113432
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5cafd7caf72bcdb7a56fa7c3196b24c8091cb050.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/91049249206) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org