You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/14 05:37:30 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8835: [explore view] fix: Inline edit chart title cause unintended overwrite original query parameter

graceguo-supercat opened a new pull request #8835: [explore view] fix: Inline edit chart title cause unintended overwrite original query parameter
URL: https://github.com/apache/incubator-superset/pull/8835
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [x] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   To reproduce this issue:
   
   1. Add a chart to dashboard,
   2. Keep edit chart, for example, use left-side controls panel to update query.
   3. Now, click chart title and inline edit chart title.
   4 Visit dashboard, you will see the original chart, both title and query are modified.
   
   Expected behavior:
   inline edit chart title should only overwrite chart title, should not change original chart with unsaved query parameters.
   
   ### TEST PLAN
   CI and manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 @michellethomas @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org