[GitHub] [incubator-weex] sunshl commented on a change in pull request #2254: [Android] Fix blank page when JS exception raised before batch end.

[GitBox <gi...@apache.org>]

sunshl commented on a change in pull request #2254: [Android] Fix blank page when JS exception raised before batch end.
URL: https://github.com/apache/incubator-weex/pull/2254#discussion_r270854702
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/ui/WXRenderManager.java
 ##########
 @@ -144,6 +165,15 @@ public void postGraphicAction(final String instanceId, final BasicGraphicAction
       return;
     }
 
+    if (mCurrentBatchInstanceId != null && instanceId != null && !mCurrentBatchInstanceId.equals(instanceId) && mBatchActions.size() > 0) {
 
 Review comment:
   If more than two pages exist and mCurrentBatchInstanceId not matches new instanceId, we will post all stashed actions at once.
   
   That will cause losing efficacy of batch action, but it is acceptable because it's not serious problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services