[GitHub] [madlib] njayaram2 commented on a change in pull request #377: DL: Do not compile params in predict and add gpu support

[GitBox <gi...@apache.org>]

njayaram2 commented on a change in pull request #377:  DL: Do not compile params in predict and add gpu support
URL: https://github.com/apache/madlib/pull/377#discussion_r279064666
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_predict.py_in
 ##########
 @@ -112,6 +114,9 @@ def predict(schema_madlib, model_table, test_table, id_col,
         class_values, intermediate_col, pred_col_name,
         pred_col_type, is_response, MODULE_NAME)
 
+    segment_id = -1 if is_platform_pg() else '{0}.gp_segment_id'.format(
 
 Review comment:
   The query that this gets used in selects from both `{test_table}` and `{model_table}`. `gp_segment_id` is an implicit column in both these tables that would lead to ambiguous column name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services