[jira] [Commented] (GROOVY-7462) groovy.json.internal.Dates instantiates objects without explicitly specifying the miliseconds parameter

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580939#comment-14580939 ] 

ASF GitHub Bot commented on GROOVY-7462:
----------------------------------------

GitHub user fmatosqg opened a pull request:

    https://github.com/apache/incubator-groovy/pull/39

    GROOVY-7462: Dates factory fix when initializing miliseconds field

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fmatosqg/incubator-groovy GROOVY-7462_fix_dates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-groovy/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit 21d92d4d43df57ef2186b908f63c3e0de8035e54
Author: Fabio de Matos <fd...@despegar.com>
Date:   2015-06-10T15:18:10Z

    GROOVY-7462: Dates factory fix when initializing miliseconds field

----


> groovy.json.internal.Dates instantiates objects without explicitly specifying the miliseconds parameter
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-7462
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7462
>             Project: Groovy
>          Issue Type: Bug
>          Components: JSON
>    Affects Versions: 2.4.3
>            Reporter: Pascal Schumacher
>            Assignee: Guillaume Laforge
>
> groovy.json.internal.Dates instantiates objects without explicitly specifying the miliseconds parameter. By omission, it ends up using the value provided by Calendar.getInstance(), which is copied over from System.currentTimeMillis(). This is a problem when comparing dates.
> Source: [https://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201506.mbox/%3CCAJ_y_NCp4EKX11DCd%3D%3D7pkoS-16Y2JBnB6xpy%2BDQenYTaOV9Ew%40mail.gmail.com%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)