[GitHub] [tomcat] uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions

[GitBox <gi...@apache.org>]

uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions
URL: https://github.com/apache/tomcat/pull/161
 
 
   Exceptions are expensive and should only be thrown in an exceptional state. End of input is no exception but should be expected. With the previous code a perfectly valid hostname will produce and process two ArrayIndexOutOfBoundsExceptions at its end, one in HttpParser.isAlpha() and one in HttpParser.isNumeric(), before detecting the end of input.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org