You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/10 01:53:17 UTC
[GitHub] [solr] madrob opened a new pull request #738: SOLR-16092 Do not fail test on slow CI servers
madrob opened a new pull request #738:
URL: https://github.com/apache/solr/pull/738
https://issues.apache.org/jira/browse/SOLR-16092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] murblanc commented on a change in pull request #738: SOLR-16092 Do not fail test on slow CI servers
Posted by GitBox <gi...@apache.org>.
murblanc commented on a change in pull request #738:
URL: https://github.com/apache/solr/pull/738#discussion_r825043404
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -50,15 +50,7 @@ public MultiThreadedOCPTest() {
}
@Test
- public void test() throws Exception {
- testParallelCollectionAPICalls();
- testTaskExclusivity();
- testDeduplicationOfSubmittedTasks();
- testLongAndShortRunningParallelApiCalls();
- testFillWorkQueue();
Review comment:
I guess it might just delay the other tests if running concurrently. Let's leave it like this and see if new problems appear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #738: SOLR-16092 Do not fail test on slow CI servers
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #738:
URL: https://github.com/apache/solr/pull/738#discussion_r824939389
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -50,15 +50,7 @@ public MultiThreadedOCPTest() {
}
@Test
- public void test() throws Exception {
- testParallelCollectionAPICalls();
- testTaskExclusivity();
- testDeduplicationOfSubmittedTasks();
- testLongAndShortRunningParallelApiCalls();
- testFillWorkQueue();
Review comment:
Turning the five private methods into top-level tests means they could run in different orders, so more realistic test coverage there as a side effect, nice.
From a quick read of the tests, they don't look like one could cause side effects that would change the baseline for the next tests. So changing order should be fine.
Am less sure though on whether or not the tests could run in parallel now then and if then they could interact with each other? The ones which create collections, the collection names are specific to each test, so no problem there at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #738: SOLR-16092 Do not fail test on slow CI servers
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #738:
URL: https://github.com/apache/solr/pull/738#discussion_r825092498
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -50,15 +50,7 @@ public MultiThreadedOCPTest() {
}
@Test
- public void test() throws Exception {
- testParallelCollectionAPICalls();
- testTaskExclusivity();
- testDeduplicationOfSubmittedTasks();
- testLongAndShortRunningParallelApiCalls();
- testFillWorkQueue();
Review comment:
I don't _think_ that we run tests from the same class concurrently in the same JVM, but that also seems like an implementation detail that we shouldn't rely on. Will watch for breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #738: SOLR-16092 Do not fail test on slow CI servers
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #738:
URL: https://github.com/apache/solr/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] murblanc commented on a change in pull request #738: SOLR-16092 Do not fail test on slow CI servers
Posted by GitBox <gi...@apache.org>.
murblanc commented on a change in pull request #738:
URL: https://github.com/apache/solr/pull/738#discussion_r825024039
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -50,15 +50,7 @@ public MultiThreadedOCPTest() {
}
@Test
- public void test() throws Exception {
- testParallelCollectionAPICalls();
- testTaskExclusivity();
- testDeduplicationOfSubmittedTasks();
- testLongAndShortRunningParallelApiCalls();
- testFillWorkQueue();
Review comment:
`MAX_PARALLEL_TASKS` in `testFillWorkQueue()` might have a cross test impact? When the queue is full, it's full.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org