You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jeff Whiting (JIRA)" <ji...@apache.org> on 2010/10/13 23:28:34 UTC

[jira] Updated: (THRIFT-955) Thrift compiler for Windows uses lowercase names and directories which is inconsistent with compiling on other platforms

     [ https://issues.apache.org/jira/browse/THRIFT-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Whiting updated THRIFT-955:
--------------------------------

    Description: 
Using thrift compiler 0.5.0 for windows found at: http://incubator.apache.org/thrift/download/ the compiler produces lowercase files and paths rather than honoring the capitalization of the thrift file.  However using the compiler on other platforms (I've tested OS X specifically), or an older compiler for windows found on the wiki, the name follows the capitalization of the thrift file.

Windows compiler now compiling AdminService.thrift you get:
./gen-php/adminservice/adminservice_constants.php
./gen-php/adminservice/adminservice_types.php
./gen-php/adminservice/AdminService.php

What you get on other OSes and what you used to get on older versions of windows compiler:
./gen-php/AdminService/AdminService_constants.php
./gen-php/AdminService/AdminService_types.php
./gen-php/AdminService/AdminService.php

This is an inconsistency that can cause lots of headaches for developers when they are in a mixed environment using both windows and other OSes to compile thrift files.  It makes it easy to get the wrong case and can cause problems for a case sensitive file system.  It seems that the compiler should behave the same regardless of the platform.

  was:
Using thrift compiler 0.5.0 for windows found at: http://incubator.apache.org/thrift/download/ the compiler produces lower case files and paths rather than honoring the capitalization of the thrift file.  However using the compiler on other platforms (or an older compiler for windows found on the wiki) the name follows the capitalization of the service.  

Windows compiler now compiling AdminService.thrift you get:
./gen-php/adminservice/adminservice_constants.php
./gen-php/adminservice/adminservice_types.php
./gen-php/adminservice/AdminService.php

What you get on other OSes and what you used to get on older versions of windows compiler:
./gen-php/AdminService/AdminService_constants.php
./gen-php/AdminService/AdminService_types.php
./gen-php/AdminService/AdminService.php

This is an inconsistency that can cause lots of headaches for developers when they are in a mixed environment using both windows and other OSes to compile thrift files.  It makes it easy to get the wrong case and can cause problems for a case sensitive file system.


> Thrift compiler for Windows uses lowercase names and directories which is inconsistent with compiling on other platforms
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-955
>                 URL: https://issues.apache.org/jira/browse/THRIFT-955
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.5
>         Environment: Windows 7 64 bit. Using thrift compiler for windows found at: http://incubator.apache.org/thrift/download/
>            Reporter: Jeff Whiting
>
> Using thrift compiler 0.5.0 for windows found at: http://incubator.apache.org/thrift/download/ the compiler produces lowercase files and paths rather than honoring the capitalization of the thrift file.  However using the compiler on other platforms (I've tested OS X specifically), or an older compiler for windows found on the wiki, the name follows the capitalization of the thrift file.
> Windows compiler now compiling AdminService.thrift you get:
> ./gen-php/adminservice/adminservice_constants.php
> ./gen-php/adminservice/adminservice_types.php
> ./gen-php/adminservice/AdminService.php
> What you get on other OSes and what you used to get on older versions of windows compiler:
> ./gen-php/AdminService/AdminService_constants.php
> ./gen-php/AdminService/AdminService_types.php
> ./gen-php/AdminService/AdminService.php
> This is an inconsistency that can cause lots of headaches for developers when they are in a mixed environment using both windows and other OSes to compile thrift files.  It makes it easy to get the wrong case and can cause problems for a case sensitive file system.  It seems that the compiler should behave the same regardless of the platform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.