You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sumerman (via GitHub)" <gi...@apache.org> on 2023/09/07 12:43:45 UTC
[GitHub] [arrow-rs] sumerman opened a new pull request, #4787: Relaxing type bounds on coalesce_ranges and collect_bytes
sumerman opened a new pull request, #4787:
URL: https://github.com/apache/arrow-rs/pull/4787
# Which issue does this PR close?
A followup to #4784
# Rationale for this change
Now that `coalesce_ranges` and `coalesce_ranges` were made public the next logical step is to relax type their type bounds. Thus allowing to use them with a wider range of `Error` types.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4787: Relaxing type bounds on coalesce_ranges and collect_bytes
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4787:
URL: https://github.com/apache/arrow-rs/pull/4787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4787: Relaxing type bounds on coalesce_ranges and collect_bytes
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4787:
URL: https://github.com/apache/arrow-rs/pull/4787#discussion_r1318637345
##########
object_store/src/util.rs:
##########
@@ -47,9 +49,13 @@ pub(crate) fn hmac_sha256(
}
/// Collect a stream into [`Bytes`] avoiding copying in the event of a single chunk
-pub async fn collect_bytes<S>(mut stream: S, size_hint: Option<usize>) -> Result<Bytes>
+pub async fn collect_bytes<S, E>(
+ mut stream: S,
+ size_hint: Option<usize>,
+) -> StdResult<Bytes, E>
Review Comment:
```suggestion
) -> Result<Bytes, E>
```
The type def just defaults to object_store::Error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org