You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "b-phi (via GitHub)" <gi...@apache.org> on 2025/06/03 17:14:24 UTC
[PR] Add v3 structs [iceberg-python]
b-phi opened a new pull request, #2065:
URL: https://github.com/apache/iceberg-python/pull/2065
Adds v3 structs for data files, manifest entries, and manifest lists.
Closes https://github.com/apache/iceberg-python/issues/1982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add v3 structs [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #2065:
URL: https://github.com/apache/iceberg-python/pull/2065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add v3 structs [iceberg-python]
Posted by "b-phi (via GitHub)" <gi...@apache.org>.
b-phi commented on code in PR #2065:
URL: https://github.com/apache/iceberg-python/pull/2065#discussion_r2124465099
##########
pyiceberg/manifest.py:
##########
@@ -289,6 +289,129 @@ def __repr__(self) -> str:
doc="ID representing sort order for this file",
),
),
+ 3: StructType(
Review Comment:
Happy to make this DRYer if desired, just followed the v1 -> v2 example initially
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add v3 structs [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #2065:
URL: https://github.com/apache/iceberg-python/pull/2065#discussion_r2144955628
##########
pyiceberg/manifest.py:
##########
@@ -289,6 +289,129 @@ def __repr__(self) -> str:
doc="ID representing sort order for this file",
),
),
+ 3: StructType(
Review Comment:
I think this is fine for now, since they won't change. I think this is less error-prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add v3 structs [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2065:
URL: https://github.com/apache/iceberg-python/pull/2065#issuecomment-2970393485
Sorry for the long wait @b-phi, but thanks for adding this 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org