[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375349589
 
 

 ##########
 File path: be/src/olap/base_compaction.cpp
 ##########
 @@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::pick_rowsets_to_compact() {
     }
 
     double base_cumulative_delta_ratio = config::base_cumulative_delta_ratio;
+    if (base_size == 0) {
 
 Review comment:
   We have checked `input_rowsets.size ` firstly, so _input_rowsets.size() at least should be 2 and the base_size should larger than zero.
   ```
      if (_input_rowsets.size() <= 1) {
           return OLAP_ERR_BE_NO_SUITABLE_VERSION;
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org