[GitHub] [netbeans] jtulach commented on a change in pull request #2773: VSCode BUILD.MD update for production build.

[GitBox <gi...@apache.org>]

jtulach commented on a change in pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#discussion_r579605848



##########
File path: java/java.lsp.server/vscode/BUILD.md
##########
@@ -35,10 +42,9 @@ To build the VS Code extension invoke:
 ```bash
 netbeans$ ant build
 netbeans$ cd java/java.lsp.server
-java.lsp.server$ ant build-vscode-ext -D3rdparty.modules=.*nbjavac.*
+java.lsp.server$ ant build-vscode-ext -Dvsix.version=x.y.z
 ```
-
-The `3rdparty.modules` property doesn't have to be set at all.

Review comment:
       Either the `3rdparty.modules` property remain to be documented, or it shall be removed. If it doesn't work with `m2://` protocol (which it didn't), that should be fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists