You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/30 00:46:53 UTC
[GitHub] [helix] jiajunwang opened a new issue #707: NoClassDefFoundError
because of WAGED rebalancer config when maintenance mode is on
jiajunwang opened a new issue #707: NoClassDefFoundError because of WAGED rebalancer config when maintenance mode is on
URL: https://github.com/apache/helix/issues/707
The root cause is that we skip the check for the WAGED rebalanced resource when maintenance mode is enabled. This causes an unexpected error print out.
We should fix the validation logic and the error message will be gone. This won't impact the correctness of pipeline logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #707: NoClassDefFoundError
because of WAGED rebalancer config when maintenance mode is on
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #707: NoClassDefFoundError because of WAGED rebalancer config when maintenance mode is on
URL: https://github.com/apache/helix/issues/707#issuecomment-580032685
IllegalName: org/apache/helix/controller/rebalancer/waged/WagedRebalancer
java.lang.ClassLoader.preDefineClass - Line 654 (ClassLoader.java)
java.lang.ClassLoader.defineClass - Line 761 (ClassLoader.java)
java.security.SecureClassLoader.defineClass - Line 142 (SecureClassLoader.java)
java.net.URLClassLoader.defineClass - Line 467 (URLClassLoader.java)
java.net.URLClassLoader.access$100 - Line 73 (URLClassLoader.java)
java.net.URLClassLoader$1.run - Line 368 (URLClassLoader.java)
java.net.URLClassLoader$1.run - Line 362 (URLClassLoader.java)
java.security.AccessController.doPrivileged - Line -2 (AccessController.java)
java.net.URLClassLoader.findClass - Line 361 (URLClassLoader.java)
org.eclipse.jetty.webapp.WebAppClassLoader.foundClass - Line 649 (WebAppClassLoader.java)
org.eclipse.jetty.webapp.WebAppClassLoader.loadClass - Line 555 (WebAppClassLoader.java)
java.lang.ClassLoader.loadClass - Line 357 (ClassLoader.java)
org.apache.helix.util.HelixUtil.loadClass - Line 133 (HelixUtil.java)
org.apache.helix.controller.stages.BestPossibleStateCalcStage.getCustomizedRebalancer - Line 424 (BestPossibleStateCalcStage.java)
org.apache.helix.controller.stages.BestPossibleStateCalcStage.getRebalancer - Line 442 (BestPossibleStateCalcStage.java)
org.apache.helix.controller.stages.BestPossibleStateCalcStage.computeSingleResourceBestPossibleState - Line 342 (BestPossibleStateCalcStage.java)
org.apache.helix.controller.stages.BestPossibleStateCalcStage.compute - Line 140 (BestPossibleStateCalcStage.java)
org.apache.helix.controller.stages.BestPossibleStateCalcStage.process - Line 85 (BestPossibleStateCalcStage.java)
org.apache.helix.controller.pipeline.Pipeline.handle - Line 68 (Pipeline.java)
org.apache.helix.controller.GenericHelixController.handleEvent - Line 728 (GenericHelixController.java)
org.apache.helix.controller.GenericHelixController.access$500 - Line 120 (GenericHelixController.java)
org.apache.helix.controller.GenericHelixController$ClusterEventProcessor.run - Line 1266 (GenericHelixController.java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #707: NoClassDefFoundError
because of WAGED rebalancer config when maintenance mode is on
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #707: NoClassDefFoundError because of WAGED rebalancer config when maintenance mode is on
URL: https://github.com/apache/helix/issues/707#issuecomment-580104266
The root cause is job resource rebalance fetching logic.
> case TASK:
> rebalancer = getCustomizedRebalancer(idealState.getRebalancerClassName(), resourceName);
> break;
It should be a potential problem in the test only. Since in prod environment, the job resources will never be configured with a Waged rebalancer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #707: NoClassDefFoundError
because of WAGED rebalancer configured for job resource.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #707: NoClassDefFoundError because of WAGED rebalancer configured for job resource.
URL: https://github.com/apache/helix/issues/707#issuecomment-580348842
It's a problematic test script. Not quite possible in a product. But the error message is a real bug though.
Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Lei Xia <no...@github.com>
Sent: Thursday, January 30, 2020 8:03:16 AM
To: apache/helix <he...@noreply.github.com>
Cc: Jiajun Wang <jj...@linkedin.com>; Assign <as...@noreply.github.com>
Subject: Re: [apache/helix] NoClassDefFoundError because of WAGED rebalancer configured for job resource. (#707)
Just curious, why a Job resource even being configured to use Waged rebalancer?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhelix%2Fissues%2F707%3Femail_source%3Dnotifications%26email_token%3DAANYM2AQAYE5PPOHUZDVV2DRAL24JA5CNFSM4KNN7UTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKLQQUQ%23issuecomment-580323410&data=02%7C01%7Cjjwang%40linkedin.com%7Cda91bb60118249cdde7408d7a59decda%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637159970016014501&sdata=khca2pIog%2FvMItBC2%2FR%2Fyh%2Bk4Wzv9UWuWVSUGoB8a8U%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAANYM2FKK3PF7OGGCXMAG3LRAL24JANCNFSM4KNN7UTA&data=02%7C01%7Cjjwang%40linkedin.com%7Cda91bb60118249cdde7408d7a59decda%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637159970016024492&sdata=WzDg0PN7n16zmKX99bSN45q3DVSDp0tiDvcukDGBPsM%3D&reserved=0>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #707: NoClassDefFoundError for
WAGED rebalancer
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #707: NoClassDefFoundError for WAGED rebalancer
URL: https://github.com/apache/helix/issues/707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] lei-xia commented on issue #707: NoClassDefFoundError
because of WAGED rebalancer configured for job resource.
Posted by GitBox <gi...@apache.org>.
lei-xia commented on issue #707: NoClassDefFoundError because of WAGED rebalancer configured for job resource.
URL: https://github.com/apache/helix/issues/707#issuecomment-580323410
Just curious, why a Job resource even being configured to use Waged rebalancer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #707: NoClassDefFoundError
because of WAGED rebalancer configured for job resource.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #707: NoClassDefFoundError because of WAGED rebalancer configured for job resource.
URL: https://github.com/apache/helix/issues/707#issuecomment-583092487
I took a closer look. Might not be related to the job resources. Let me try if I can reproduce the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #707: NoClassDefFoundError
for WAGED rebalancer
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #707: NoClassDefFoundError for WAGED rebalancer
URL: https://github.com/apache/helix/issues/707#issuecomment-583165043
It is most likely to be a lib version mismatch. As I checked the code, if there is any logic error, the class should be able to initialize the same, and we will get a casting failure instead of class not found.
Close this issue since it is only seen in the tests with the new build (and mixed lib version probably).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org