You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matteo Sotil (JIRA)" <ji...@apache.org> on 2011/09/06 12:30:10 UTC

[jira] [Created] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
-----------------------------------------------------------------------------------------------------------------------------------------

                 Key: WICKET-4030
                 URL: https://issues.apache.org/jira/browse/WICKET-4030
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5-RC7
            Reporter: Matteo Sotil
            Priority: Minor


In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098651#comment-13098651 ] 

Matteo Sotil edited comment on WICKET-4030 at 9/7/11 6:42 AM:
--------------------------------------------------------------

In fact, response.renderCSSReference("css/main.css")  was the first thing I tried, but it did'nt work.

Now I see I've simplified too much the quickstart; the issue is produced when wicket filter is different than /*, too. I've updated issue summary and description to reflect it. In quickstart, try changing wicket filter mapping like this:

        <filter-mapping>
		<filter-name>wicket.myproject</filter-name>
		<url-pattern>/wicket/*</url-pattern>
	</filter-mapping>

Then use response.renderCSSReference("css/main.css") as you said. You will see that generated href is ../css/main.css, wich points to http://localhost:8080/contextPath/wicket/css/main.css, when it should be ../../css/main.css to point to http://localhost:8080/contextPath/css/main.css, because css path passed to renderCSSReference should be _context-relative_ path, and not wicket-filter-url-pattern relative, isn't it?.

      was (Author: msotil):
    In fact, response.renderCSSReference("css/main.css")  was the first thing I tried, but it did'nt work.

Now I see I've simplified too much the quickstart; the issue is produced when wicket filter is different than /*, too. In quickstart, try changing wicket filter mapping like this:

        <filter-mapping>
		<filter-name>wicket.myproject</filter-name>
		<url-pattern>/wicket/*</url-pattern>
	</filter-mapping>

Then use response.renderCSSReference("css/main.css") as you said. You will see that generated href is ../css/main.css, wich points to http://localhost:8080/contextPath/wicket/css/main.css, when it should be ../../css/main.css to point to http://localhost:8080/contextPath/css/main.css, because css path passed to renderCSSReference should be _context-relative_ path, and not wicket-filter-url-pattern relative, isn't it?.
  
> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>
> In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098651#comment-13098651 ] 

Matteo Sotil commented on WICKET-4030:
--------------------------------------

In fact, response.renderCSSReference("css/main.css")  was the first thing I tried, but it did'nt work.

Now I see I've simplified too much the quickstart; the issue is produced when wicket filter is different than /*, too. In quickstart, try changing wicket filter mapping like this:

        <filter-mapping>
		<filter-name>wicket.myproject</filter-name>
		<url-pattern>/wicket/*</url-pattern>
	</filter-mapping>

Then use response.renderCSSReference("css/main.css") as you said. You will see that generated href is ../css/main.css, wich points to http://localhost:8080/contextPath/wicket/css/main.css, when it should be ../../css/main.css to point to http://localhost:8080/contextPath/css/main.css, because css path passed to renderCSSReference should be _context-relative_ path, and not wicket-filter-url-pattern relative, isn't it?.

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098144#comment-13098144 ] 

Peter Ertl commented on WICKET-4030:
------------------------------------

The problem is:

response.renderCSSReference(path) expects a context-relative(!) path (see javadoc). This is not to be confused with the effective path that get's rendered.

basically what you did wrong is call

  response.renderCSSReference("../css/main.css") 

when instead you should use the _context-relative_ path (relative to "/contextPath" in your sample).

So the correct method call is

  response.renderCSSReference("css/main.css") 

It will work no matter how you mount your home page or if you mount it at all. In any case wicket will generate the required number of ".." in the path.


> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl reassigned WICKET-4030:
----------------------------------

    Assignee: Peter Ertl

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-4030.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.1

resourcereference urls should be filter relative. raw urls given by the user should be context-relative.

the patch was bad because it made all urls context-relative - which broke resource refrence urls.

headerresponse already had a relative() function which shouldve taken care of the conversion but was probably not rewritten correctly when we switched it to use url renderer.

fixed, thanks for reporting.

> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.5.1
>
>         Attachments: quickstart.zip, relative-url.patch
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Description: In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.  (was: In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.)
        Summary: HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*  (was: HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*)

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098651#comment-13098651 ] 

Matteo Sotil edited comment on WICKET-4030 at 9/7/11 7:08 AM:
--------------------------------------------------------------

In fact, response.renderCSSReference("css/main.css")  was the first thing I tried, but it did'nt work.

Now I see that the real condition to reproduce the issue is using a wicket filter url pattern different than /*. I've updated issue summary, description and quickstart to reflect it. In quickstart, I changed wicket filter mapping like this:

        <filter-mapping>
		<filter-name>wicket.myproject</filter-name>
		<url-pattern>/wicket/*</url-pattern>
	</filter-mapping>

Now context path is /*, HomePage is not mounted, so application url is http://localhost:8080/wicket.
Now I use response.renderCSSReference("css/main.css") as should be. 

You will see that generated href is css/main.css, wich points to http://localhost:8080/wicket/css/main.css, when it should be ../css/main.css to point to http://localhost:8080/css/main.css, because css path passed to renderCSSReference should be _context-relative_ path, and not wicket-filter-url-pattern relative, isn't it?.

      was (Author: msotil):
    In fact, response.renderCSSReference("css/main.css")  was the first thing I tried, but it did'nt work.

Now I see I've simplified too much the quickstart; the issue is produced when wicket filter is different than /*, too. I've updated issue summary and description to reflect it. In quickstart, try changing wicket filter mapping like this:

        <filter-mapping>
		<filter-name>wicket.myproject</filter-name>
		<url-pattern>/wicket/*</url-pattern>
	</filter-mapping>

Then use response.renderCSSReference("css/main.css") as you said. You will see that generated href is ../css/main.css, wich points to http://localhost:8080/contextPath/wicket/css/main.css, when it should be ../../css/main.css to point to http://localhost:8080/contextPath/css/main.css, because css path passed to renderCSSReference should be _context-relative_ path, and not wicket-filter-url-pattern relative, isn't it?.
  
> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl resolved WICKET-4030.
--------------------------------

    Resolution: Invalid

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Attachment: quickstart.zip

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098877#comment-13098877 ] 

Peter Ertl commented on WICKET-4030:
------------------------------------

@Matteo: Indeed the current javadoc is wrong. The rendering happens relative to wicket filter root both in current wicket release 1.4.18 and 1.5.0. I sent a mail to the developer mailing list to clarify that issue. Currently the solution will be to properly escape the filter path with '..' to access context relative resources.


> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098654#comment-13098654 ] 

Matteo Sotil edited comment on WICKET-4030 at 9/7/11 7:12 AM:
--------------------------------------------------------------

I update quickstart to reflect new conditions required to reproduce the issue.
Execute Start, go to http://localhost:8080/wicket. If renderCSSReference worked properly, background color should be red (that means css is loaded correctly), but it is not. 

      was (Author: msotil):
    I update quickstart to reflect new conditions required to reproduce the issue.
  
> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Summary: HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*  (was: HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*)

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl reopened WICKET-4030:
--------------------------------


> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Attachment:     (was: quickstart.zip)

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>
> In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Summary: HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url  (was: HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*)

> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-4030:
-------------------------------

    Attachment: relative-url.patch

added patch in case we want to fix this...

> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip, relative-url.patch
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (WICKET-4030) HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-4030:
---------------------------------------

    Assignee: Igor Vaynberg  (was: Peter Ertl)

@Igor: do you know what is the expected behavior of this method ?

> HeaderResponse.renderCSSReference does not render context path relative url, but wicket filter url-pattern relative url
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Igor Vaynberg
>            Priority: Minor
>         Attachments: quickstart.zip, relative-url.patch
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Attachment:     (was: quickstart.zip)

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with wicket filter url-pattern different than /*
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not context relative, but wicket url-pattern relative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097876#comment-13097876 ] 

Matteo Sotil edited comment on WICKET-4030 at 9/6/11 10:58 AM:
---------------------------------------------------------------

Quickstart of the issue. Execute Start, go to http://localhost:8080/contextPath. If renderCSSReference worked properly, background color should be red (that means css is loaded correctly), but it is not.

      was (Author: msotil):
    Quickstart of the issue. Execute Start, go to http://localhost:8080/contextPath. If renderrCSSReference works properly, background color should be red, bu it is not.
  
> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Attachment: quickstart.zip

Quickstart of the issue. Execute Start, go to http://localhost:8080/contextPath. If renderrCSSReference works properly, background color should be red, bu it is not.

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Attachment: quickstart.zip

I update quickstart to reflect new conditions required to reproduce the issue.

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /* and wicket filter url-pattern different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4030) HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*

Posted by "Matteo Sotil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Sotil updated WICKET-4030:
---------------------------------

    Description: In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.  (was: In an application with a contextPath different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a relative url (../../css/main.css, for example), the generated css link is not correct when page path has some /.)

> HeaderResponse.renderCSSReference does not render correct css link with relative url in an application with contextPath different than /*
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4030
>                 URL: https://issues.apache.org/jira/browse/WICKET-4030
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Matteo Sotil
>            Assignee: Peter Ertl
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> In an application with a contextPath different than /*, and a wicket filter url-pattern different than /*, if you use HeaderResponse.renderCSSReference(String url), where url is a context-path-relative url (css/main.css, for example), the generated css link is not correct when page path has some /.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira