[GitHub] drill issue #709: DRILL-5156: BootStrapContext should close threads

[sudheeshkatkam <gi...@git.apache.org>]

Github user sudheeshkatkam commented on the issue:

    https://github.com/apache/drill/pull/709
  
    This change may not be that simple, but I could be wrong. I tried to do something similar as part of [PR 429](https://github.com/apache/drill/pull/429/commits/0394f4caffff5aed142bb2ba0b192f3588cfda7b).
    
    The close happens elsewhere. The "loop" is actually closed as part of 
    [BasicServer#close](https://github.com/apache/drill/blob/master/exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java#L218). But it will be closed multiple times (because there may be multiple instances of sub-classes of BasicServer, and all use the same loop), and looks like "loop2" is not closed anywhere. The changes in PR 429 close the loops exactly once, but I do not recollect why the PR is not merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---