[GitHub] [couchdb] jaydoane commented on a diff in pull request #4056: Optimize couch_key_tree:find_missing/2

[GitBox <gi...@apache.org>]

jaydoane commented on code in PR #4056:
URL: https://github.com/apache/couchdb/pull/4056#discussion_r894121076


##########
src/couch/test/eunit/couch_key_tree_tests.erl:
##########
@@ -534,7 +557,7 @@ should_not_use_excessive_memory_when_stemming() ->
     ?_test(begin
         % This is to preserve determinism
         Seed = {1647, 841737, 351137},
-        Tree = generate_rev_tree(1000, 0.006, Seed),
+        {_, Tree} = test_util:revtree_generate(1000, 0.06, 15, Seed),

Review Comment:
   Nice!



##########
src/couch/test/eunit/couch_key_tree_tests.erl:
##########
@@ -44,7 +44,9 @@ key_tree_missing_leaves_test_() ->
         "Missing tree leaves",
         [
             should_not_find_missing_leaves(),
-            should_find_missing_leaves()
+            should_find_missing_leaves(),
+            should_not_find_missing_leaves_large_test(),
+            should_find_missing_leave_large_test()

Review Comment:
   Should this have an "s" on "leaves", e.g. `should_find_missing_leaves_large_test`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org