[jira] [Closed] (TAP5-2479) Improvement of SessionApplicationStatePersistenceStrategy

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jochen Kemnade closed TAP5-2479.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 5.4

Yes, this isn't going to have a large impact, but it's a sensible change, thanks.

> Improvement of SessionApplicationStatePersistenceStrategy
> ---------------------------------------------------------
>
>                 Key: TAP5-2479
>                 URL: https://issues.apache.org/jira/browse/TAP5-2479
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Maria Fedotova
>            Priority: Trivial
>              Labels: patch
>             Fix For: 5.4
>
>         Attachments: TAP5-2479.patch
>
>
> This patch is little improvement in method exists of SessionApplicationStatePersistenceStrategy.
> {code}
> public <T> boolean exists(Class<T> ssoClass)
>     {
>         String key = buildKey(ssoClass);
>         Session session = request.getSession(false);
>         return session != null && session.getAttribute(key) != null;
>     }
> {code}
> We changed the code so that the key is built only when the session is not null.
> This code didn't have effect on time per request, but I think it's useful.
> Thank [~mihasik] for the idea.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)