You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/09/20 21:16:07 UTC

DO NOT REPLY [Bug 51852] New: BeanELResolver varargs handling is broken in multiple ways

https://issues.apache.org/bugzilla/show_bug.cgi?id=51852

             Bug #: 51852
           Summary: BeanELResolver varargs handling is broken in multiple
                    ways
           Product: Tomcat 7
           Version: trunk
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Servlet & JSP API
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: mbenson@apache.org
    Classification: Unclassified


The supplied patch (against SVN Revision 1173292) addresses:
 - Incorrectly constructed varargs arguments (resulting in
ArrayIndexOutOfBoundsExceptions)
 - Incorrectly detected matching varargs methods

I originally encountered the first issue in my JSF application using the JUEL
EL implementation in conjunction with Tomcat's EL API.  However I continue to
get the error even when dropping JUEL from the application, so I'm not sure why
in some instances the Jasper implementation seems to handle the varargs
invocations and in others the BeanELResolver is invoked.  In any event, code
that already resides in BeanELResolver should certainly function properly, and
mixing a given ExpressionFactory implementation with any conforming API
implementation should AFAICT be feasible.

The second issue I encountered while debugging the first issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51852] BeanELResolver varargs handling is broken in multiple ways

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2011-09-21 13:41:56 UTC ---
Many thanks for the patch and especially for including the test case.

The patch has been applied to trunk and 7.0.x and will be included in 7.0.22
onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51852] BeanELResolver varargs handling is broken in multiple ways

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852

--- Comment #1 from Matt Benson <mb...@apache.org> 2011-09-20 19:17:16 UTC ---
Created attachment 27543
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27543
Proposed patch

I grant the ASF license to incorporate the contents of the submitted patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51852] BeanELResolver varargs handling is broken in multiple ways

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852

Matt Benson <mb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mbenson@apache.org
         OS/Version|                            |All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org