You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Greg Stein <gs...@lyra.org> on 2003/08/11 22:41:52 UTC
Re: cvs commit: incubator-geronimo/modules/core/src/java/javax/ejb/spi HandleDelegate.java
On Mon, Aug 11, 2003 at 10:41:21AM -0000, jstrachan@apache.org wrote:
> jstrachan 2003/08/11 03:41:21
>...
> Log:
> Tidied up imports, removing unused ones & sorting them.
>
> Revision Changes Path
> 1.2 +106 -105 incubator-geronimo/modules/core/src/java/org/apache/geronimo/lock/LockContext.java
>
> http://cvs.apache.org/viewcvs/incubator-geronimo/modules/core/src/java/org/apache/geronimo/lock/LockContext.java.diff?r1=1.1&r2=1.2
What is going on here? The changed line counts don't match up with the log
message. Is there more screwy line endings stuff going on here?
I'm not sure what is going on with the line endings, and whether they've
been fixed, but we really cannot let them flip back and forth like this. It
means the commit emails are unreviewable, which is Not Good(tm).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: incubator-geronimo/modules/core/src/java/javax/ejb/spi HandleDelegate.java
Posted by Greg Stein <gs...@lyra.org>.
On Mon, Aug 11, 2003 at 01:55:20PM -0700, Jeremy Boynes wrote:
> If I read it correctly they do: the +1,105 means "added, start at 1, count
> 105" not "added 1105"
> > > Revision Changes Path
> > > 1.2 +106 -105
> > incubator-geronimo/modules/core/src/java/org/apache/geronimo/lock/
> > LockContext.java
Hunh? It says +106 -105 which doesn't mesh well with the log message. I
can't see LockContext.java having that many lines of imports :-)
> This was a mess following the initial import with spurious CR characters.
> Hopefully this is now resolved for everything and the deltas will start to
> make sense.
Excellent.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
RE: cvs commit: incubator-geronimo/modules/core/src/java/javax/ejb/spi HandleDelegate.java
Posted by Jeremy Boynes <je...@coredevelopers.net>.
If I read it correctly they do: the +1,105 means "added, start at 1, count
105" not "added 1105"
This was a mess following the initial import with spurious CR characters.
Hopefully this is now resolved for everything and the deltas will start to
make sense.
--
Jeremy
> -----Original Message-----
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Monday, August 11, 2003 1:42 PM
> To: geronimo-dev@incubator.apache.org
> Subject: Re: cvs commit:
> incubator-geronimo/modules/core/src/java/javax/ejb/spi
> HandleDelegate.java
>
>
> On Mon, Aug 11, 2003 at 10:41:21AM -0000, jstrachan@apache.org wrote:
> > jstrachan 2003/08/11 03:41:21
> >...
> > Log:
> > Tidied up imports, removing unused ones & sorting them.
> >
> > Revision Changes Path
> > 1.2 +106 -105
> incubator-geronimo/modules/core/src/java/org/apache/geronimo/lock/
> LockContext.java
> >
> >
> http://cvs.apache.org/viewcvs/incubator-geronimo/modules/core/src/
java/org/apache/geronimo/lock/LockContext.java.diff?r1=1.1&r2=1.2
>
> What is going on here? The changed line counts don't match up with the log
> message. Is there more screwy line endings stuff going on here?
>
> I'm not sure what is going on with the line endings, and whether they've
> been fixed, but we really cannot let them flip back and forth
> like this. It
> means the commit emails are unreviewable, which is Not Good(tm).
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>