You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/10 14:24:00 UTC
[jira] [Commented] (TINKERPOP-832) Remove deprecated
addV/E/InE/OutE methods
[ https://issues.apache.org/jira/browse/TINKERPOP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080391#comment-16080391 ]
ASF GitHub Bot commented on TINKERPOP-832:
------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/657
TINKERPOP-832: Remove deprecated addV/E/InE/OutE methods
https://issues.apache.org/jira/browse/TINKERPOP-832
Removed deprecated `addV()`, `addE()`, `addInE()`, and `addOutE()` methods that are no longer supported given the introduction of the `to()` and `from()` modulators. This is actually a very good deprecation to remove as there is a lot of extraneous testing (and bug proneness) around these methods given the complicated interactions with the desired overloaded methods of the same name -- lots of parameter type checking and validation (gross).
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-832
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/657.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #657
----
commit 1e034535b0bc896beff497ed9473fcfa8b70e876
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-07-10T14:14:54Z
Removed ancient deprecated mutation steps of addV(), addE(), and addOutE(), addInE(). These are no longer needed given the introduction of to() and from() constructs.
----
> Remove deprecated addV/E/InE/OutE methods
> -----------------------------------------
>
> Key: TINKERPOP-832
> URL: https://issues.apache.org/jira/browse/TINKERPOP-832
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> The related methods are on {{GraphTraversal}}, {{__}} and {{GraphTraversalSource}}. It should be noted that these are public methods likely utilized by end-users.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)