You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/04 18:28:36 UTC
[GitHub] [incubator-doris] xinyiZzz opened a new pull request #6380: [BUG] Fixed BE crash when Select Stmt does not contain the Slot of the Union Node on the right side of Join
xinyiZzz opened a new pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380
fix #6327
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6327) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#issuecomment-901581042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r688288202
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
##########
@@ -125,6 +126,62 @@ public void addChild(PlanNode node, List<Expr> resultExprs) {
return materializedConstExprLists_;
}
+ @Override
+ public void finalize(Analyzer analyzer) throws UserException {
+ // In Doris-6380, moved computePassthrough() and the materialized position of resultExprs/constExprs from this.init()
Review comment:
please add some unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6380: [BUG] Fixed BE crash when select stmt and on-clause does not contain the Slot of the Union Node on the build side of Join
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r685703603
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1838,6 +1837,11 @@ public PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, PlanNode inner
*/
private PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, TableRef innerRef,
SelectStmt selectStmt) throws UserException {
+ // Before creating a build node, ensure that all required slots are materialized,
+ // even if slots that are not needed by Statement outside.
+ // Otherwise, when select stmt and on-clause does not contain the Slot of the Union Node on the right side of Join,
+ // it will cause an error, see Doris-6380.
+ materializeTableResultForCrossJoinOrCountStar(innerRef, analyzer);
Review comment:
I understand to ensure that resultExprs/constExprs and the corresponding output slot are materialized in the same state.
The output slot is materialized at various positions in the planner stage.
So I moved the materialized position of resultExprs/constExprs from SetOperationNode.init to SetOperationNode.finalize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r689110259
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
##########
@@ -125,6 +126,62 @@ public void addChild(PlanNode node, List<Expr> resultExprs) {
return materializedConstExprLists_;
}
+ @Override
+ public void finalize(Analyzer analyzer) throws UserException {
+ // In Doris-6380, moved computePassthrough() and the materialized position of resultExprs/constExprs from this.init()
+ // to this.finalize(), and will not call SetOperationNode::init() again at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move computePassthrough():
+ // Because the byteSize of the tuple corresponding to OlapScanNode is updated after
+ // singleNodePlanner.createSingleNodePlan() and before singleNodePlan.finalize(),
+ // calling computePassthrough() in SetOperationNode::init() may not be able to accurately determine whether
+ // the child is pass through. In the previous logic , Will call SetOperationNode::init() again
+ // at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move materialized position of resultExprs/constExprs:
+ // Because the output slot is materialized at various positions in the planner stage, this is to ensure that
+ // eventually the resultExprs/constExprs and the corresponding output slot have the same materialized state.
+ // And the order of materialized resultExprs must be the same as the order of child adjusted by
+ // computePassthrough(), so resultExprs materialized must be placed after computePassthrough().
+
+ // except Node must not reorder the child
+ if (!(this instanceof ExceptNode)) {
+ computePassthrough(analyzer);
+ }
+ // drop resultExprs/constExprs that aren't getting materialized (= where the
+ // corresponding output slot isn't being materialized)
+ materializedResultExprLists_.clear();
+ Preconditions.checkState(resultExprLists_.size() == children.size());
+ List<SlotDescriptor> slots = analyzer.getDescTbl().getTupleDesc(tupleId_).getSlots();
+ for (int i = 0; i < resultExprLists_.size(); ++i) {
+ List<Expr> exprList = resultExprLists_.get(i);
+ List<Expr> newExprList = Lists.newArrayList();
+ Preconditions.checkState(exprList.size() == slots.size());
+ for (int j = 0; j < exprList.size(); ++j) {
+ if (slots.get(j).isMaterialized()) {
+ newExprList.add(exprList.get(j));
+ }
+ }
+ materializedResultExprLists_.add(
+ Expr.substituteList(newExprList, getChild(i).getOutputSmap(), analyzer, true));
+ }
+ Preconditions.checkState(
+ materializedResultExprLists_.size() == getChildren().size());
+
+ materializedConstExprLists_.clear();
+ for (List<Expr> exprList : constExprLists_) {
+ Preconditions.checkState(exprList.size() == slots.size());
+ List<Expr> newExprList = Lists.newArrayList();
+ for (int i = 0; i < exprList.size(); ++i) {
+ if (slots.get(i).isMaterialized()) {
+ newExprList.add(exprList.get(i));
+ }
+ }
+ materializedConstExprLists_.add(newExprList);
+ }
+ super.finalize(analyzer);
Review comment:
that's right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6380: [BUG] Fixed BE crash when select stmt and on-clause does not contain the Slot of the Union Node on the build side of Join
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r683222613
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1838,6 +1837,11 @@ public PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, PlanNode inner
*/
private PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, TableRef innerRef,
SelectStmt selectStmt) throws UserException {
+ // Before creating a build node, ensure that all required slots are materialized,
+ // even if slots that are not needed by Statement outside.
+ // Otherwise, when select stmt and on-clause does not contain the Slot of the Union Node on the right side of Join,
+ // it will cause an error, see Doris-6380.
+ materializeTableResultForCrossJoinOrCountStar(innerRef, analyzer);
Review comment:
Changing the order is not a good way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6380: [BUG] Fixed BE crash when select stmt and on-clause does not contain the Slot of the Union Node on the build side of Join
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r685703603
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1838,6 +1837,11 @@ public PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, PlanNode inner
*/
private PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, TableRef innerRef,
SelectStmt selectStmt) throws UserException {
+ // Before creating a build node, ensure that all required slots are materialized,
+ // even if slots that are not needed by Statement outside.
+ // Otherwise, when select stmt and on-clause does not contain the Slot of the Union Node on the right side of Join,
+ // it will cause an error, see Doris-6380.
+ materializeTableResultForCrossJoinOrCountStar(innerRef, analyzer);
Review comment:
I understand to ensure that resultExprs/constExprs and the corresponding output slot are materialized in the same state.
The output slot is materialized at various positions in the planner stage.
So I moved the materialized position of resultExprs/constExprs from this.init to this.finalize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6380: [BUG] Fixed BE crash when select stmt and on-clause does not contain the Slot of the Union Node on the build side of Join
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r683222613
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1838,6 +1837,11 @@ public PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, PlanNode inner
*/
private PlanNode createJoinNode(Analyzer analyzer, PlanNode outer, TableRef innerRef,
SelectStmt selectStmt) throws UserException {
+ // Before creating a build node, ensure that all required slots are materialized,
+ // even if slots that are not needed by Statement outside.
+ // Otherwise, when select stmt and on-clause does not contain the Slot of the Union Node on the right side of Join,
+ // it will cause an error, see Doris-6380.
+ materializeTableResultForCrossJoinOrCountStar(innerRef, analyzer);
Review comment:
Changing the order is not a good way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#issuecomment-901581107
The unit test failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r689110331
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
##########
@@ -125,6 +126,62 @@ public void addChild(PlanNode node, List<Expr> resultExprs) {
return materializedConstExprLists_;
}
+ @Override
+ public void finalize(Analyzer analyzer) throws UserException {
+ // In Doris-6380, moved computePassthrough() and the materialized position of resultExprs/constExprs from this.init()
Review comment:
wait wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r689110259
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
##########
@@ -125,6 +126,62 @@ public void addChild(PlanNode node, List<Expr> resultExprs) {
return materializedConstExprLists_;
}
+ @Override
+ public void finalize(Analyzer analyzer) throws UserException {
+ // In Doris-6380, moved computePassthrough() and the materialized position of resultExprs/constExprs from this.init()
+ // to this.finalize(), and will not call SetOperationNode::init() again at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move computePassthrough():
+ // Because the byteSize of the tuple corresponding to OlapScanNode is updated after
+ // singleNodePlanner.createSingleNodePlan() and before singleNodePlan.finalize(),
+ // calling computePassthrough() in SetOperationNode::init() may not be able to accurately determine whether
+ // the child is pass through. In the previous logic , Will call SetOperationNode::init() again
+ // at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move materialized position of resultExprs/constExprs:
+ // Because the output slot is materialized at various positions in the planner stage, this is to ensure that
+ // eventually the resultExprs/constExprs and the corresponding output slot have the same materialized state.
+ // And the order of materialized resultExprs must be the same as the order of child adjusted by
+ // computePassthrough(), so resultExprs materialized must be placed after computePassthrough().
+
+ // except Node must not reorder the child
+ if (!(this instanceof ExceptNode)) {
+ computePassthrough(analyzer);
+ }
+ // drop resultExprs/constExprs that aren't getting materialized (= where the
+ // corresponding output slot isn't being materialized)
+ materializedResultExprLists_.clear();
+ Preconditions.checkState(resultExprLists_.size() == children.size());
+ List<SlotDescriptor> slots = analyzer.getDescTbl().getTupleDesc(tupleId_).getSlots();
+ for (int i = 0; i < resultExprLists_.size(); ++i) {
+ List<Expr> exprList = resultExprLists_.get(i);
+ List<Expr> newExprList = Lists.newArrayList();
+ Preconditions.checkState(exprList.size() == slots.size());
+ for (int j = 0; j < exprList.size(); ++j) {
+ if (slots.get(j).isMaterialized()) {
+ newExprList.add(exprList.get(j));
+ }
+ }
+ materializedResultExprLists_.add(
+ Expr.substituteList(newExprList, getChild(i).getOutputSmap(), analyzer, true));
+ }
+ Preconditions.checkState(
+ materializedResultExprLists_.size() == getChildren().size());
+
+ materializedConstExprLists_.clear();
+ for (List<Expr> exprList : constExprLists_) {
+ Preconditions.checkState(exprList.size() == slots.size());
+ List<Expr> newExprList = Lists.newArrayList();
+ for (int i = 0; i < exprList.size(); ++i) {
+ if (slots.get(i).isMaterialized()) {
+ newExprList.add(exprList.get(i));
+ }
+ }
+ materializedConstExprLists_.add(newExprList);
+ }
+ super.finalize(analyzer);
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6380: [BUG] Fixed the materialized number of resultExprs/constExprs and output slot of Union Node is inconsistent.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6380:
URL: https://github.com/apache/incubator-doris/pull/6380#discussion_r688285440
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
##########
@@ -125,6 +126,62 @@ public void addChild(PlanNode node, List<Expr> resultExprs) {
return materializedConstExprLists_;
}
+ @Override
+ public void finalize(Analyzer analyzer) throws UserException {
+ // In Doris-6380, moved computePassthrough() and the materialized position of resultExprs/constExprs from this.init()
+ // to this.finalize(), and will not call SetOperationNode::init() again at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move computePassthrough():
+ // Because the byteSize of the tuple corresponding to OlapScanNode is updated after
+ // singleNodePlanner.createSingleNodePlan() and before singleNodePlan.finalize(),
+ // calling computePassthrough() in SetOperationNode::init() may not be able to accurately determine whether
+ // the child is pass through. In the previous logic , Will call SetOperationNode::init() again
+ // at the end of createSetOperationNodeFragment().
+ //
+ // Reasons for move materialized position of resultExprs/constExprs:
+ // Because the output slot is materialized at various positions in the planner stage, this is to ensure that
+ // eventually the resultExprs/constExprs and the corresponding output slot have the same materialized state.
+ // And the order of materialized resultExprs must be the same as the order of child adjusted by
+ // computePassthrough(), so resultExprs materialized must be placed after computePassthrough().
+
+ // except Node must not reorder the child
+ if (!(this instanceof ExceptNode)) {
+ computePassthrough(analyzer);
+ }
+ // drop resultExprs/constExprs that aren't getting materialized (= where the
+ // corresponding output slot isn't being materialized)
+ materializedResultExprLists_.clear();
+ Preconditions.checkState(resultExprLists_.size() == children.size());
+ List<SlotDescriptor> slots = analyzer.getDescTbl().getTupleDesc(tupleId_).getSlots();
+ for (int i = 0; i < resultExprLists_.size(); ++i) {
+ List<Expr> exprList = resultExprLists_.get(i);
+ List<Expr> newExprList = Lists.newArrayList();
+ Preconditions.checkState(exprList.size() == slots.size());
+ for (int j = 0; j < exprList.size(); ++j) {
+ if (slots.get(j).isMaterialized()) {
+ newExprList.add(exprList.get(j));
+ }
+ }
+ materializedResultExprLists_.add(
+ Expr.substituteList(newExprList, getChild(i).getOutputSmap(), analyzer, true));
+ }
+ Preconditions.checkState(
+ materializedResultExprLists_.size() == getChildren().size());
+
+ materializedConstExprLists_.clear();
+ for (List<Expr> exprList : constExprLists_) {
+ Preconditions.checkState(exprList.size() == slots.size());
+ List<Expr> newExprList = Lists.newArrayList();
+ for (int i = 0; i < exprList.size(); ++i) {
+ if (slots.get(i).isMaterialized()) {
+ newExprList.add(exprList.get(i));
+ }
+ }
+ materializedConstExprLists_.add(newExprList);
+ }
+ super.finalize(analyzer);
Review comment:
The super function is generally placed on the first line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org