You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/08 15:45:00 UTC
[jira] [Commented] (DRILL-8040) Return an HTTP error code from
failed REST API operations
[ https://issues.apache.org/jira/browse/DRILL-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440562#comment-17440562 ]
ASF GitHub Bot commented on DRILL-8040:
---------------------------------------
dzamo opened a new pull request #2366:
URL: https://github.com/apache/drill/pull/2366
# [DRILL-8040](https://issues.apache.org/jira/browse/DRILL-8040): Return an HTTP error code from failed REST API operations
(Please replace `PR Title` with actual PR Title)
## Description
Multiple REST API operations, notably affecting storage config operations, return an error message with an HTTP status code of 200 when an operation fails. The web UI depends on this behaviour in some places. REST clients should receive an HTTP error code instead.
There are some subtleties. Submitting a new query than later goes on to fail in execution still sees a 200 returned for the query submission. The storage plugin store does not raise an error if you try to delete something that it does not contain, so deleting something nonexistent is still a 200.
## Documentation
Add a note indicating that failed operations will generally result in an HTTP error code.
## Testing
- Existing test coverage.
- Send invalid requests to the REST API and check HTTP response code
- Use all pages of the web UI to test that normal functionality is still working, while monitoring XHR requests made from the browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Return an HTTP error code from failed REST API operations
> ---------------------------------------------------------
>
> Key: DRILL-8040
> URL: https://issues.apache.org/jira/browse/DRILL-8040
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 1.20.0
>
>
> Multiple REST API operations, notably affecting storage config operations, return an error message with an HTTP status code of 200 when an operation fails. The web UI depends on this behaviour in some places. REST clients should receive an HTTP error code instead.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)