[jira] [Commented] (IGNITE-7967) DataRegionMetrics#totalAllocatedPages is invalid if metrics were enabled at runtime

["Dmitriy Sorokin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589126#comment-16589126 ] 

Dmitriy Sorokin commented on IGNITE-7967:
-----------------------------------------

[~agura] While working on this task, I discovered several problems that I also fixed in this context:
 # Wrong points of metric update at PageMemoryNoStoreImpl class;
 # File header size was added to value of 'allocated' field of FilePageStore class, but substracted at usages of that value;
 # Incorrect calculation of totalPersistenceSize variable value at the checkMetricsConsistency method of IgnitePdsDataRegionMetricsTest class;
 # Every-time creation of no-op implementation of AllocatedPageTracker interface instead usage of singleton;
 # ClusterNodeMetricsSelfTest and DataRegionMetricsSelfTest was fixed according to new metric behaviour.

> DataRegionMetrics#totalAllocatedPages is invalid if metrics were enabled at runtime
> -----------------------------------------------------------------------------------
>
>                 Key: IGNITE-7967
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7967
>             Project: Ignite
>          Issue Type: Bug
>          Components: persistence
>    Affects Versions: 2.3
>            Reporter: Alexey Goncharuk
>            Assignee: Dmitriy Sorokin
>            Priority: Major
>              Labels: iep-6
>             Fix For: 2.7
>
>
> {{totalAllocatedPages}} is updated during runtime via callback. When metrics are enabled at runtime, some pages may be already allocated, thus the metric shows invalid value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)