You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@trafficserver.apache.org by Sudheer Vinukonda <su...@yahoo.com> on 2020/03/06 17:49:53 UTC
proxy.config.body_factory.response_suppression_mode config change
We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to mallocs/locks etc in request path -- we need to improve that, but that's a bit outside the scope of this email).Looking at the configs, we have proxy.config.body_factory.response_suppression_mode which can take the below values today. It looks like 2 (`2`` = suppress response pages only for intercepted traffic) is not used at all looking through the code. Discussed with Bryan over slack and we think it's reasonable to repurpose `2` as `2`` = suppress response pages only for internal traffic.Let me know if there are any concerns.https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode
.. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
Specifies when Traffic Server suppresses generated response pages:
- ``0`` = never suppress generated response pages
- ``1`` = always suppress generated response pages
- ``2`` = suppress response pages only for intercepted traffic
-- Sudheer
Re: proxy.config.body_factory.response_suppression_mode config
change
Posted by Sudheer Vinukonda <su...@yahoo.com>.
After discussing with Bryan and Alan, I'm going to go ahead with the change to repurpose the currently dead setting `2` to mean ``2`` = suppress response pages only for *internal* traffic
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for *internal* traffic
Thanks,
Sudheer
On Friday, March 6, 2020, 11:48:18 AM PST, Bryan Call <bc...@apache.org> wrote:
+1 - Looks good to me.
-Bryan
> On Mar 6, 2020, at 9:49 AM, Sudheer Vinukonda <su...@yahoo.com> wrote:
>
> We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to mallocs/locks etc in request path -- we need to improve that, but that's a bit outside the scope of this email).
> Looking at the configs, we have proxy.config.body_factory.response_suppression_mode which can take the below values today. It looks like
> 2 (`2`` = suppress response pages only for intercepted traffic) is not used at all looking through the code. Discussed with Bryan over slack and we think it's reasonable to repurpose `2` as `2`` = suppress response pages only for internal traffic.
> Let me know if there are any concerns.
> https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode <https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode>
>
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for intercepted traffic
>
> -- Sudheer
>
Re: proxy.config.body_factory.response_suppression_mode config
change
Posted by Sudheer Vinukonda <su...@yahoo.com.INVALID>.
After discussing with Bryan and Alan, I'm going to go ahead with the change to repurpose the currently dead setting `2` to mean ``2`` = suppress response pages only for *internal* traffic
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for *internal* traffic
Thanks,
Sudheer
On Friday, March 6, 2020, 11:48:18 AM PST, Bryan Call <bc...@apache.org> wrote:
+1 - Looks good to me.
-Bryan
> On Mar 6, 2020, at 9:49 AM, Sudheer Vinukonda <su...@yahoo.com> wrote:
>
> We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to mallocs/locks etc in request path -- we need to improve that, but that's a bit outside the scope of this email).
> Looking at the configs, we have proxy.config.body_factory.response_suppression_mode which can take the below values today. It looks like
> 2 (`2`` = suppress response pages only for intercepted traffic) is not used at all looking through the code. Discussed with Bryan over slack and we think it's reasonable to repurpose `2` as `2`` = suppress response pages only for internal traffic.
> Let me know if there are any concerns.
> https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode <https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode>
>
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for intercepted traffic
>
> -- Sudheer
>
Re: proxy.config.body_factory.response_suppression_mode config change
Posted by Bryan Call <bc...@apache.org>.
+1 - Looks good to me.
-Bryan
> On Mar 6, 2020, at 9:49 AM, Sudheer Vinukonda <su...@yahoo.com> wrote:
>
> We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to mallocs/locks etc in request path -- we need to improve that, but that's a bit outside the scope of this email).
> Looking at the configs, we have proxy.config.body_factory.response_suppression_mode which can take the below values today. It looks like
> 2 (`2`` = suppress response pages only for intercepted traffic) is not used at all looking through the code. Discussed with Bryan over slack and we think it's reasonable to repurpose `2` as `2`` = suppress response pages only for internal traffic.
> Let me know if there are any concerns.
> https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode <https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode>
>
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for intercepted traffic
>
> -- Sudheer
>
Re: proxy.config.body_factory.response_suppression_mode config change
Posted by Bryan Call <bc...@apache.org>.
+1 - Looks good to me.
-Bryan
> On Mar 6, 2020, at 9:49 AM, Sudheer Vinukonda <su...@yahoo.com> wrote:
>
> We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to mallocs/locks etc in request path -- we need to improve that, but that's a bit outside the scope of this email).
> Looking at the configs, we have proxy.config.body_factory.response_suppression_mode which can take the below values today. It looks like
> 2 (`2`` = suppress response pages only for intercepted traffic) is not used at all looking through the code. Discussed with Bryan over slack and we think it's reasonable to repurpose `2` as `2`` = suppress response pages only for internal traffic.
> Let me know if there are any concerns.
> https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode <https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-body-factory-response-suppression-mode>
>
> .. ts:cv:: CONFIG proxy.config.body_factory.response_suppression_mode INT 0
> Specifies when Traffic Server suppresses generated response pages:
> - ``0`` = never suppress generated response pages
> - ``1`` = always suppress generated response pages
> - ``2`` = suppress response pages only for intercepted traffic
>
> -- Sudheer
>