[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8698: add explodeSpec

[GitBox <gi...@apache.org>]

SEKIRO-J commented on a change in pull request #8698: add explodeSpec
URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343962102
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/impl/FileIteratingFirehose.java
 ##########
 @@ -77,8 +82,22 @@ public InputRow nextRow() throws IOException
     if (!hasMore()) {
       throw new NoSuchElementException();
     }
+    if (!parsedInputRows.isEmpty()) {
+      return parsedInputRows.remove(0);
 
 Review comment:
   Cool, it's a good idea, I was worrying about this issue too.
   Tried to use LinkedList so that's O(1) pop, but I wonder why it's a forbidden API? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org