You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/25 08:55:05 UTC

[GitHub] [spark] cloud-fan edited a comment on pull request #29785: [SPARK-32901][CORE] Do not allocate memory while spilling UnsafeExternalSorter

cloud-fan edited a comment on pull request #29785:
URL: https://github.com/apache/spark/pull/29785#issuecomment-698810109


   Is it possible to refactor it a little bit to make the logic simpler? It's really tricky that we must be careful at each step, in case something was spilled right before the step.
   
   I'm fine if refactoring is too hard and merge the PR as it is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org