You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/06/09 08:59:28 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2621: add uuid support for java and kotlin
Jimexist opened a new pull request, #2621:
URL: https://github.com/apache/thrift/pull/2621
add uuid support for java and kotlin
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2621:
URL: https://github.com/apache/thrift/pull/2621#issuecomment-1169168148
Why is this closed? That was not the plan ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on a diff in pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G commented on code in PR #2621:
URL: https://github.com/apache/thrift/pull/2621#discussion_r893907435
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -1910,6 +1916,9 @@ void t_java_generator::generate_java_struct_parcelable(ostream& out, t_struct* t
scope_down(out);
} else {
switch (bt->get_base()) {
+ case t_base_type::TYPE_I8:
Review Comment:
This probably manifested because I added those "default" cases (I got a ton of compilation errors about that on my Linux machine) but I really wonder why this particular missing case has not been detected before by the C++ compiler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on a diff in pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G commented on code in PR #2621:
URL: https://github.com/apache/thrift/pull/2621#discussion_r893907435
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -1910,6 +1916,9 @@ void t_java_generator::generate_java_struct_parcelable(ostream& out, t_struct* t
scope_down(out);
} else {
switch (bt->get_base()) {
+ case t_base_type::TYPE_I8:
Review Comment:
This probably manifested because I added those "default" cases (I got a ton of compilation errors about that on my Linux machine) but I really wonder why this particular missing case has not been detected before by the C++ compiler?
EDIT: Ah, found it. You only moved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on a diff in pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G commented on code in PR #2621:
URL: https://github.com/apache/thrift/pull/2621#discussion_r893907435
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -1910,6 +1916,9 @@ void t_java_generator::generate_java_struct_parcelable(ostream& out, t_struct* t
scope_down(out);
} else {
switch (bt->get_base()) {
+ case t_base_type::TYPE_I8:
Review Comment:
This probably manifested because I added the default branch (I got a ton of warnings about that on my Linux machine) but I really wonder why this particular missing case has not been detected before by the C++ compiler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2621:
URL: https://github.com/apache/thrift/pull/2621#issuecomment-1151625381
merged to `uuid-datatype` branch in 3ee561d84b56294605676b8a3bc7b4d07ff594e1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2621: THRIFT-5587: add uuid support for java and kotlin
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2621: THRIFT-5587: add uuid support for java and kotlin
URL: https://github.com/apache/thrift/pull/2621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org