[jira] [Commented] (KYLIN-3847) Flink cubing step : fact distinct

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055614#comment-17055614 ] 

ASF GitHub Bot commented on KYLIN-3847:
---------------------------------------

harveyyue commented on pull request #1154: KYLIN-3847 Flink cubing step : fact distinct
URL: https://github.com/apache/kylin/pull/1154
 
 
   Refer jira: https://issues.apache.org/jira/browse/KYLIN-3847
   Add flink fact distinct columns step, to avoid a mass of duplicated code with Spark and Flink implement self fact distinct step, add base class FactDistinctColumnsBase, extract core methods and variables from mapper/reducer class.  
   About different engine will implement the abstract method FactDistinctColumnsBase.Visitor.collect(...) to output the result from Spark/Flink engine framework.
   Please help to review this code changes 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink cubing step : fact distinct
> ---------------------------------
>
>                 Key: KYLIN-3847
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3847
>             Project: Kylin
>          Issue Type: Sub-task
>          Components: Flink Engine
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)