You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/01/20 06:30:12 UTC

[GitHub] AprliRainkun opened a new pull request #112: Load X509 cert on client creation

AprliRainkun opened a new pull request #112: Load X509 cert on client creation
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/112
 
 
   This PR proposes a fix for issue #111. Changes are:
   * Execute `LoadX509Cert` when creating `Client`, instead of making requests.
   * Prefer to use the provided `Transport` (from `httpClient` argument  of `NewClient`), only create a new `Transport` when user sets `Cert`, `Key` and `Insecure`.
   * Fix some go vet suggestions.
   
   BTW, I've submitted the Apache CLA and I'm waiting for the confirmation email.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services